Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-hgx72 Correct the validation sequence for HGCal #17103

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

bsunanda
Copy link
Contributor

No description provided.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 29, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17169/console Started: 2016/12/29 21:27

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Validation/Configuration

@civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Dec 30, 2016

+1

for #17103 7f1a24c

  • updates in Validation/Configuration/python/hgcalSimValid_cff.py. Reco is not affected
  • jenkins tests pass and comparisons show no differences

@civanch
Copy link
Contributor

civanch commented Jan 3, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1
are the V6 versions now obsolete and thus can be removed?

@cmsbuild cmsbuild merged commit 78092c5 into cms-sw:CMSSW_9_0_X Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants