Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [[cms::thread_safe]] attrib to statics #1712

Merged
merged 2 commits into from Dec 9, 2013
Merged

add [[cms::thread_safe]] attrib to statics #1712

merged 2 commits into from Dec 9, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 6, 2013

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

add [[cms::thread_safe]] attrib to statics

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.


// ----------------------------------------------------------------------
template <typename KEY, typename T, typename E>
ThreadSafeRegistry<KEY,T,E>*
ThreadSafeRegistry<KEY,T,E>::instance() {
static ThreadSafeRegistry<KEY,T,E> me;
[[edm::thread_safe]] static ThreadSafeRegistry<KEY,T,E> me;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's not mark this one as thread-safe. Instead, we could mark some of its member functions as thread safe.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

Pull request #1712 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@ktf
Copy link
Contributor

ktf commented Dec 9, 2013

Ciao Patrick, please use git rebase -i to squash fixup commits like the "not this one" one.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 9, 2013
Multithreading fixes -- Add [[cms::thread_safe]] attrib to statics
@ktf ktf merged commit fb8881c into cms-sw:CMSSW_7_0_X Dec 9, 2013
@gartung gartung deleted the fwcore-utilities-attribs branch December 10, 2013 15:50
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance L1Trigger/L1TCalorimeter to V01-00-05.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants