New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [[cms::thread_safe]] attrib to statics #1712
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. add [[cms::thread_safe]] attrib to statics It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
||
// ---------------------------------------------------------------------- | ||
template <typename KEY, typename T, typename E> | ||
ThreadSafeRegistry<KEY,T,E>* | ||
ThreadSafeRegistry<KEY,T,E>::instance() { | ||
static ThreadSafeRegistry<KEY,T,E> me; | ||
[[edm::thread_safe]] static ThreadSafeRegistry<KEY,T,E> me; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, let's not mark this one as thread-safe. Instead, we could mark some of its member functions as thread safe.
Pull request #1712 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
Ciao Patrick, please use |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Add [[cms::thread_safe]] attrib to statics
Advance L1Trigger/L1TCalorimeter to V01-00-05.
No description provided.