Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FORTRAN warnings in ME2pythia.f #17166

Merged
merged 1 commit into from Jan 13, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 12, 2017

This seems to be written in FORTRAN 77 (decades old standard). These
warnings:

Warning: Legacy Extension: Comma before i/o item list at (1)

to GNU FORTRAN extension "6.1.7 I/O item lists":

To support legacy codes, GNU Fortran allows the input item list of
the READ statement, and the output item lists of the WRITE and PRINT
statements, to start with a comma.

The patch removes the commas.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

This seems to be written in FORTRAN 77 (decades old standard). These
warnings:

    Warning: Legacy Extension: Comma before i/o item list at (1)

to GNU FORTRAN extension "6.1.7 I/O item lists":

    To support legacy codes, GNU Fortran allows the input item list of
    the READ statement, and the output item lists of the WRITE and PRINT
    statements, to start with a comma.

The patch removes the commas.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

GeneratorInterface/PartonShowerVeto

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@govoni
Copy link
Contributor

govoni commented Jan 12, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17256/console Started: 2017/01/12 19:04

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a18029 into cms-sw:CMSSW_9_0_X Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants