Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set type info in TypeWithDict ctor #1717

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 6, 2013

Fixed a failure of three framework unit tests in the ROOT 6 branch due to the failure to properly initialize the ti_ (type_info) data member of TypeWithDict in the constructor from a TClass pointer.

There are 37 other framework unit tests also failing. Fixes for many of those should be coming soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Properly set type info in TypeWithDict ctor

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Dec 6, 2013
…Ctor

Properly set type info in TypeWithDict ctor
@davidlt davidlt merged commit 8b30523 into cms-sw:CMSSW_7_0_ROOT6_X Dec 6, 2013
@wmtan wmtan deleted the ProperlySetTypeInfoInTypeWithDictCtor branch December 9, 2013 22:17
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants