Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up import statements to only import what is necessary. #17197

Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jan 17, 2017

Note that the change in patPFMETCorrections_cff moves the
import * in the right direction and allows fixing the other
files, but leaves more work to be done elsewhere in another PR.

Note that the change in patPFMETCorrections_cff moves the
import * in the right direction and allows fixing the other
files, but leaves more work to be done elsewhere in another PR.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_9_0_X.

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 17, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17316/console Started: 2017/01/18 00:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 18, 2017

+1

for #17197 6b6caf3

  • modified as described
  • jenkins tests pass and comparisons show no differences

@monttj
Copy link
Contributor

monttj commented Jan 18, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 689b7ed into cms-sw:CMSSW_9_0_X Jan 18, 2017
@wddgit wddgit deleted the from-CMSSW_9_0_X_2017-01-17-1100 branch August 2, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants