Add dtors with noexcept(false) to match C++ requirements

[davidlt]

Compiler generated default dtor is noexcept(true) (i.e. not throwing),
but these classes are used as base classes where parent class dtor is
marked as noexcept(false) (i.e. throwing). This is not allowed.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17354/console Started: 2017/01/20 22:34

[cmsbuild]

-1

Tested at: 69caf17

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17237/17354/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimTracker/TrackHistory/src/HistoryBase.cc 
>> Building LCG reflex dict from header file src/SimTracker/TrackHistory/src/classes.h
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimTracker/TrackHistory/src/TrackClassifier.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimTracker/TrackHistory/src/TrackHistory.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimG4Core/GFlash/src/GflashHadronWrapperProcess.cc:4:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimG4Core/GFlash/interface/GflashHadronWrapperProcess.h:14:60: error: expected class-name before '{' token
 class GflashHadronWrapperProcess : public G4WrapperProcess {
                                                            ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-1100/src/SimG4Core/GFlash/interface/GflashHadronWrapperProcess.h:18:39: error: expected ')' before 'processName'
   GflashHadronWrapperProcess(G4String processName); 
                                       ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[davidlt]

Looks to be not related and suspicious:

/cvmfs/cms-ib.cern.ch/nweek-02455/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-01-20-1100/external/slc6_amd64_gcc530/lib/libCore.so: file not recognized: File truncated
collect2: error: ld returned 1 exit status

[davidlt]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17361/console Started: 2017/01/21 10:20

[cmsbuild]

-1

Tested at: 69caf17

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17237/17361/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-2300/src/SimG4Core/GFlash/src/GflashHadronWrapperProcess.cc:4:
/cvmfs/cms-ib.cern.ch/nweek-02455/slc6_amd64_gcc530/external/geant4/10.02.p02-oenich2/include/Geant4/G4WrapperProcess.hh:1:1: warning: null character(s) ignored
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-2300/src/SimG4Core/GFlash/src/GflashHadronShowerModel.cc 
Entering library rule at SimTracker/TrackHistory
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-2300/src/SimG4Core/GFlash/src/GflashHadronWrapperProcess.cc:4:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-2300/src/SimG4Core/GFlash/interface/GflashHadronWrapperProcess.h:14:60: error: expected class-name before '{' token
 class GflashHadronWrapperProcess : public G4WrapperProcess {
                                                            ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-20-2300/src/SimG4Core/GFlash/interface/GflashHadronWrapperProcess.h:18:39: error: expected ')' before 'processName'
   GflashHadronWrapperProcess(G4String processName); 
                                       ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[davidlt]

Tested locally with the same IB + SCRAM_ARCH and it compiled just fine.

[davidlt]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17365/console Started: 2017/01/21 15:24

[davidlt]

Looks like the 3rd time it was okay and now it's running the tests.

[cmsbuild]

+1
Tested at: 69caf17
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17237/17365/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17237/17365/summary.html

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[Dr15Jones]

I would have expected more base classes would need to be changed.

[davidlt]

Let's see how it goes in IBs. The last IB already had "just" 16179 errors ;)

[davidlange6]

+1