New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace buf/sprintf to std::to_string #17255
Conversation
According to compiler (GCC 7) we need at least 11 bytes in the buffer. Replace buf + sprintf (unsafe) with std::to_string. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
According to compiler (GCC 7) we need at least 11 bytes in the buffer.
Replace buf + sprintf (unsafe) with std::to_string.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch