Make HCAL TP LUT generation for Phase2 more robust.

[matz-e]

The current code crashes for Phase2. Instead of generating all possible
DetIds and testing which ones are allowed, it is a lot cleaner to just
iterate over the produced metadata ids.

[cmsbuild]

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[rekovic]

+1

Now after the latest commit, this PR, fixes simHcalTriggerPrimitiveDigis to run successfully in Phase2. Together with PR #17248, this PR runs successfully steps DIGI,L1,DIGI2RAW,HLT,as in the example

step2 --python_filename=step2_L1TStage2_in_Phase2.py --no_exec -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@fake --datatier GEN-SIM-DIGI-RAW -n 1 --era Phase2C2 --eventcontent FEVTDEBUGHLT --filein root://eoscms//eos/cms/store/group/dpg_trigger/comm_trigger/L1Trigger/rekovic/HGCAL/8_2_0/step1_ZEE.root --conditions 90X_upgrade2023_realistic_v1 --era Phase2C2_timing --beamspot HLLHC14TeV --geometry Extended2023D4 --fileout file:step2_ZEE_1ev_L1TStage2_in_Phase2.root
where, L1 is Stage2.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17416/console Started: 2017/01/24 22:02

[cmsbuild]

+1
Tested at: 24fe9a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17260/17416/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17260/17416/summary.html