Remove char buffer and sprintf with std::string/std::to_string #17270
Conversation
Originally I expected ROOT classes to support std::string, but they actually take const char * instead thus I had to use .c_str(), which is not the nicest code. Hopefully ROOT classess makes a copy and not just saves the pointer internally as std::string will be temporaries. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: Validation/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Originally I expected ROOT classes to support std::string, but they
actually take const char * instead thus I had to use .c_str(), which is
not the nicest code. Hopefully ROOT classess makes a copy and not just
saves the pointer internally as std::string will be temporaries.
We should make sure we don't have dangling pointers somewhere here.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch