Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup throw specifier and boost stuff #17273

Merged
merged 2 commits into from Jan 25, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 25, 2017

Basically throw dynamic exception specifier was deprecated in C++11 and removed in C++17. Also some things like boost::shared_ptr and boost::tuples::tie + boost::tuple are now available under C++ standard library thus we should avoid external dependency -- boost. There is now alternative for boost::format, but that could still be rewritten.

David Abdurachmanov added 2 commits January 25, 2017 05:58
Throw was deprecated in C++11 and removed in C++17.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
We should avoid boost where possible and rely on C++ standard library.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Jan 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17425/console Started: 2017/01/25 07:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jan 25, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff8decc into cms-sw:CMSSW_9_0_X Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants