Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace forward decl for PFTrackTransformer with full header incl #17274

Merged
merged 1 commit into from Jan 27, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 25, 2017

Looks like now std::unique_ptr uses sizeof(_Tp) thus we need to know
full class layout.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Looks like now `std::unique_ptr` uses `sizeof(_Tp)` thus we need to know
full class layout.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @makortel, @rafaellopesdesa, @lgray, @cbernet, @bachtis this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Jan 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17426/console Started: 2017/01/25 07:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2017

+1

for #17274 0a3ceb3

  • technical change as described
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

davidlange6 commented Jan 27, 2017 via email

@cmsbuild cmsbuild merged commit c37f676 into cms-sw:CMSSW_9_0_X Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants