New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace forward decl for PFTrackTransformer with full header incl #17274
Conversation
Looks like now `std::unique_ptr` uses `sizeof(_Tp)` thus we need to know full class layout. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: RecoParticleFlow/PFTracking @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1
… On Jan 27, 2017, at 4:51 PM, cmsbuild ***@***.***> wrote:
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Looks like now
std::unique_ptr
usessizeof(_Tp)
thus we need to knowfull class layout.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch