Silent warning due to missing templates in PhaseII #17290
Conversation
|
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_9_0_X. It involves the following packages: DQM/TrackingMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| @@ -18,6 +18,9 @@ | |||
| PropagatorOpposite = cms.string("RungeKuttaTrackerPropagatorOpposite") | |||
| ) | |||
|
|
|||
| from Configuration.Eras.Modifier_trackingPhase2PU140_cff import trackingPhase2PU140 | |||
| trackingPhase2PU140.toModify(materialDumperAnalyzer, TrackerRecHitBuilder='WithTrackAngle') | |||
There was a problem hiding this comment.
I'd suggest to use phase2_tracker sub-era instead. All other TTRHBuilder instances are customized with that, and not using templates is more a property of the "detector", than a property of "tracking", even if we have only 1 phase2 tracking configuration at the moment.
The materialDumpAnalyser uses internally a refitter to extract the angle of incidence of the track with respect to the sensor surface. The refitter uses 'angleAndTemplate', that in PhaseII is missing. This PR drops the template part.
rovere
force-pushed
the
SilentTemplateWarnInMatDumper
branch
from
8396439
to
cc1ab83
Compare
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
The materialDumpAnalyser uses internally a refitter to
extract the angle of incidence of the track with respect to
the sensor surface. The refitter uses 'angleAndTemplate',
that in PhaseII is missing. This PR drops the template
part.