Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype DB connect/auth configuration #17295

Merged
merged 3 commits into from Feb 7, 2017

Conversation

kkotov
Copy link
Contributor

@kkotov kkotov commented Jan 26, 2017

I add the prototype DB connect and authentication strings to the L1O2O configuration.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkotov (Khristian Kotov) for CMSSW_9_0_X.

It involves the following packages:

CondTools/L1TriggerExt

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kkotov
Copy link
Contributor Author

kkotov commented Jan 26, 2017

I am not sure why git shows that only one file was modified (although, my commits seems all to be in). The following 6 files were in fact changed:
CondTools/L1TriggerExt/python/L1ConfigTSCKeysExt_cff.py
CondTools/L1TriggerExt/python/L1ConfigTSCPayloadsExt_cff.py
CondTools/L1TriggerExt/test/L1ConfigWriteIOVDummyExt_cfg.py
CondTools/L1TriggerExt/test/L1ConfigWritePayloadOnlineExt_cfg.py
CondTools/L1TriggerExt/test/L1ConfigWriteSinglePayloadExt_cfg.py
CondTools/L1TriggerExt/scripts/runL1-O2O-iov.sh
as can be seen from details on commit # 50bbfec above

@ggovi
Copy link
Contributor

ggovi commented Jan 30, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17501/console Started: 2017/01/30 18:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Feb 7, 2017

+1

1 similar comment
@ggovi
Copy link
Contributor

ggovi commented Feb 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5eb437b into cms-sw:CMSSW_9_0_X Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants