Phase1 improvements: adding Online configuration for timing scan and rebinning moving few plots #17340
Conversation
fioriNTU
commented
Jan 31, 2017
•
fioriNTU
commented
- Performance improvement in histogram management
- Fix bugs in pixel maps
- Fix profile errors to be on the mean
- Adding FPIX map as one plot
- Make booking process more precise
- Change plot arrangement
- Change binning of some plot
- Adding an online cfg for timing scan allowing superimposition of relevant plots
This is possible thanks to the large restructuring some time ago.
Conflicts: DQM/SiPixelPhase1Common/python/HistogramManager_cfi.py DQM/SiPixelPhase1Digis/python/SiPixelPhase1Digis_cfi.py
|
A new Pull Request was created by @fioriNTU for CMSSW_9_0_X. It involves the following packages: DQM/Integration @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
fioriNTU
changed the title
|
@enochnotsocool @davidcarbonis @lunik1 @leggat you may be interested |
|
@dmitrijus could you start he tests please? |
|
Can someone start also this test? I see quiet some activity on github ... |
|
@dmitrijus could you start the tests please? |
|
please test |
|
The tests are being triggered in jenkins. |
| @@ -0,0 +1,182 @@ | |||
| import FWCore.ParameterSet.Config as cms | |||
There was a problem hiding this comment.
The file name should be pixel_timing_scan_dqm_sourceclient-live_cfg.py or similar. No touching anything after "dqm_".
There was a problem hiding this comment.
If this is intended to run in online DQM, you will need to write an email to core DQM once this is merged and this code reaches the online DQM. We will need to properly link it, so the daemon picks it up and cmsRuns it.
If it is not intended to run in online DQM, please move this file elsewhere. Preferably outside DQM/Integration.
There was a problem hiding this comment.
@dmitrijus I have removed the file in the DQM/Integration directory and renamed it properly in our SiPixelPhase1/Config folder. In the case we will decide to use it Online I will make a separate PR. It is important to have this merged as soon as possible, in the way new contributors can play with a "quasi-final" version of the code without struggling with private branche etc ...
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #17340 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #17340 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
@dmitrijus can you restart the tests? |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
