Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFormats/TrackingRecHit : Changes needed to compile with macOS clang and libc++ #17352

Merged
merged 2 commits into from Feb 3, 2017
Merged

DataFormats/TrackingRecHit : Changes needed to compile with macOS clang and libc++ #17352

merged 2 commits into from Feb 3, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 31, 2017

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 31, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

DataFormats/TrackingRecHit

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @gpetruc, @VinInn this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@gartung gartung changed the title Changes needed to compile with macOS clang and libc++ DataFormats/Trajectory : Changes needed to compile with macOS clang and libc++ Jan 31, 2017
@slava77
Copy link
Contributor

slava77 commented Feb 1, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17560/console Started: 2017/02/01 12:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

+1
Tested at: e9fef9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17352/17560/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17352/17560/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

slava77
slava77 reviewed Feb 2, 2017
View reviewed changes
DataFormats/TrackingRecHit/src/classes_def.xml Outdated
@@ -31,7 +31,7 @@
<class name="edm::ClonePolicy<TrackingRecHit>"/> <!-- Root6 -->
<class name="edm::Ref<edm::OwnVector<TrackingRecHit,edm::ClonePolicy<TrackingRecHit> >,TrackingRecHit,edm::refhelper::FindUsingAdvance<edm::OwnVector<TrackingRecHit,edm::ClonePolicy<TrackingRecHit> >,TrackingRecHit> >"/>
<class name="edm::RefVectorIterator<edm::OwnVector<TrackingRecHit,edm::ClonePolicy<TrackingRecHit> >,TrackingRecHit,edm::refhelper::FindUsingAdvance<edm::OwnVector<TrackingRecHit,edm::ClonePolicy<TrackingRecHit> >,TrackingRecHit> >"/>
<class pattern="std::iterator<*edm::Ref*>"/>
<!--<class pattern="std::iterator<*edm::Ref*>"/>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment inline to clarify why it's commented out.

@Dr15Jones are the std::iterators actually usable? I suppose the iterators are not streamed and this is here for iteration in FWLite

Copy link
Member Author

@gartung gartung Feb 2, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning: Unused class rule: std::iterator<*edm::Ref*>
config/SCRAM/GMake/Makefile.rules:1998: recipe for target 'tmp/osx1012_amd64_clang8/src/DataFormats/TrackingRecHit/src/DataFormatsTrackingRecHit/a/DataFormatsTrackingRecHit_xr.cc' failed
gmake: *** [tmp/osx1012_amd64_clang8/src/DataFormats/TrackingRecHit/src/DataFormatsTrackingRecHit/a/DataFormatsTrackingRecHit_xr.cc] Error 1
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@gartung gartung changed the title DataFormats/Trajectory : Changes needed to compile with macOS clang and libc++ DataFormats/TrackingRecHit : Changes needed to compile with macOS clang and libc++ Feb 2, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Pull request #17352 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2017

+1

for #17352 0746a55

  • technical; the commented out selection should probably be removed eventually
  • jenkins tests pass OK for e9fef9d

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17587/console Started: 2017/02/02 14:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

+1
Tested at: 0746a55
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17352/17587/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17352/17587/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1e85c8a into cms-sw:CMSSW_9_0_X Feb 3, 2017
@gartung gartung deleted the DataFormats-TrackingRecHit-macos-clang-fixes branch March 13, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @slava77 @davidlange6