Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the HCAL DetId in error message instead of just the (useless) tower id #17389

Merged

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Feb 2, 2017

See title… this clarifies one of the LUT error messages a bit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17604/console Started: 2017/02/03 09:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

@davidlange6 davidlange6 merged commit f40de2e into cms-sw:CMSSW_9_0_X Feb 7, 2017
@matz-e matz-e deleted the hcal-better-error-message-LUT-size branch September 15, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants