Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unscoped name for enums #1744

Merged
merged 1 commit into from Dec 9, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 9, 2013

Fixed a failing framework unit test in the ROOT6 branch. ROOT stores enum names without scoping qualifiers, so unscoped names must be used to find enum members of classes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Use unscoped name for enums

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Dec 9, 2013
@davidlt davidlt merged commit 0ec97aa into cms-sw:CMSSW_7_0_ROOT6_X Dec 9, 2013
@wmtan wmtan deleted the UseUnscopedNameForEnums branch December 11, 2013 22:44
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance RecoEgamma/PhotonIdentification data to V01-00-03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants