Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert HLTTauRefProducer from legacy filter to global filter #17449

Merged
merged 3 commits into from Feb 14, 2017

Conversation

knoepfel
Copy link
Contributor

@knoepfel knoepfel commented Feb 7, 2017

Very few actual changes required to convert from legacy to global.

  • Removed unused functions.
  • Adjusted doXYZ(...) functions to be const-qualified and take only a reference to an edm::Event.
  • Made local variable doID for doElectrons so as to avoid changing values of class members during a multi-threaded context.
  • General C++ improvements: use range-for's, automatic type deduction, replace push_back with emplace_back, etc.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

A new Pull Request was created by @knoepfel (Kyle Knoepfel) for CMSSW_9_0_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@knoepfel
Copy link
Contributor Author

@Dr15Jones

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17761/console Started: 2017/02/13 15:05

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 59473aa into cms-sw:CMSSW_9_0_X Feb 14, 2017
@knoepfel knoepfel deleted the convert-HLTTauRefProducer branch March 17, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants