HCAL TP Geometry changes for plan1, phase2 #17469

matz-e · 2017-02-09T08:27:37Z

Add some bits to fully activate phase2, and add some placeholders to activate for plan1.

cmsbuild · 2017-02-09T08:27:53Z

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG
Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

rekovic · 2017-02-09T08:59:00Z

Please test

cmsbuild · 2017-02-09T08:59:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17710/console Started: 2017/02/09 10:00
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17711/console Started: 2017/02/09 10:31

cmsbuild · 2017-02-09T09:57:27Z

-1

Tested at: 0572ef0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17469/17711/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelIterator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalDbOmds.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CaloOnlineTools/HcalOnlineDb/src/WriteL1TriggerObjetsXml.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc: In member function 'unsigned int CaloTPGTranscoderULUT::getOutputLUTSize(const HcalTrigTowerDetId&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:207:10: error: expected primary-expression before 'else'
          else if (id.ietaAbs() <= theTopology->lastHERing())
          ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:209:10: error: 'else' without a previous 'if'
          else
          ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/Geometry/HcalTowerAlgo/test/HcalGeometryDump.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/Geometry/HcalTowerAlgo/test/HcalGeometryTester.cc 
Entering library rule at src/CalibCalorimetry/CaloTPG/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/plugins/CaloTPGTranscoderULUTs.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:207:10: error: expected expression
         else if (id.ietaAbs() <= theTopology->lastHERing())
         ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-08-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc:209:10: error: expected expression
         else
         ^

cmsbuild · 2017-02-09T09:57:30Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-02-09T10:01:09Z

Pull request #17469 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

rekovic · 2017-02-09T10:02:19Z

please test

cmsbuild · 2017-02-09T10:02:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17712/console Started: 2017/02/09 11:03

cmsbuild · 2017-02-09T12:24:28Z

+1
Tested at: ce68c69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17469/17712/summary.html

cmsbuild · 2017-02-09T12:24:31Z

Comparison job queued.

cmsbuild · 2017-02-10T11:59:25Z

Pull request #17469 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

ianna · 2017-02-10T12:05:13Z

please test

cmsbuild · 2017-02-10T12:05:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17731/console Started: 2017/02/10 14:53

cmsbuild · 2017-02-10T17:23:29Z

+1
Tested at: 8927d07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17469/17731/summary.html

cmsbuild · 2017-02-10T17:23:32Z

Comparison job queued.

cmsbuild · 2017-02-10T19:13:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17469/17731/summary.html

ianna · 2017-02-10T20:15:52Z

+1

franzoni · 2017-02-13T22:04:17Z

CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc

+            return QIE8_OUTPUT_LUT_SIZE;
+         else
+            return QIE10_OUTPUT_LUT_SIZE;
+      case HcalTopologyMode::TriggerMode_2017plan1:


hello @matz-e
the case 2017plan1
is the baseline for CMS at this stage: are you planning on implementing it any time soon?
At this moment,

case HcalTopologyMode::TriggerMode_2017plan1:

would proceed to execute the:

case HcalTopologyMode::TriggerMode_2018:

block, which is a worse approximation of TriggerMode_2017plan1 than TriggerMode_2017 is.

Yes, I plan on getting the implementation done as soon as this is in and we fix the gain widths needed for the LUTs.

hi @matz-e - for the next iteration - a small lookup table that lets you rewrite all this code as return lutSIze_[id.ietaAbs]; might be worth considering.

franzoni · 2017-02-14T10:05:10Z

+1

davidlange6 · 2017-02-15T19:09:55Z

hi- @matz-e -looks like this is causing problems in the relvals. Is there a quick fix?

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc530/CMSSW_9_0_X_2017-02-14-2300/pyRelValMatrixLogs/run/10826.0_QCD_Pt_600_800_13+QCD_Pt_600_800_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_QCD_Pt_600_800_13+QCD_Pt_600_800_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

davidlange6 · 2017-02-16T09:24:23Z

Seems that there is not - will revert for now - just remake this PR with a fix. Thanks

matz-e · 2017-02-16T09:47:16Z

Sorry, just got in. I'll have a look at a fix and will remake it.

matz-e · 2017-02-16T15:14:12Z

@davidlange6 This is due to the geometry being used from the DB, and me redefining the enum values. I'll fix that with my other open PR, by keeping the meaning of the integers in the enum constant, and adjusting labels.

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 9, 2017

cmsbuild added alca-pending comparison-pending geometry-pending l1-pending orp-pending pending-signatures tests-pending labels Feb 9, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 9, 2017

cmsbuild added comparison-notrun tests-rejected comparison-pending tests-pending and removed comparison-pending tests-started comparison-notrun tests-rejected labels Feb 9, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 9, 2017

cmsbuild added l1-pending tests-pending labels Feb 10, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 10, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 10, 2017

cmsbuild added geometry-approved and removed geometry-pending labels Feb 10, 2017

franzoni reviewed Feb 13, 2017

View reviewed changes

cmsbuild added alca-approved and removed alca-pending labels Feb 14, 2017

davidlange6 merged commit 763413e into cms-sw:CMSSW_9_0_X Feb 14, 2017

davidlange6 mentioned this pull request Feb 16, 2017

Revert "HCAL TP Geometry changes for plan1, phase2" #17532

Merged

matz-e mentioned this pull request Feb 16, 2017

HCAL TP for Plan 1 #17540

Merged

abdoulline mentioned this pull request Feb 23, 2017

HE Plan1 workflow for 2017 #17605

Merged

matz-e deleted the hcal-tp-geometry-plan1-phase2 branch September 15, 2017 15:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HCAL TP Geometry changes for plan1, phase2 #17469

HCAL TP Geometry changes for plan1, phase2 #17469

matz-e commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

rekovic commented Feb 9, 2017

cmsbuild commented Feb 9, 2017 •

edited

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

rekovic commented Feb 9, 2017

cmsbuild commented Feb 9, 2017 •

edited

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 10, 2017

ianna commented Feb 10, 2017

cmsbuild commented Feb 10, 2017 •

edited

cmsbuild commented Feb 10, 2017

cmsbuild commented Feb 10, 2017

cmsbuild commented Feb 10, 2017

ianna commented Feb 10, 2017

franzoni Feb 13, 2017

matz-e Feb 14, 2017

davidlange6 Feb 14, 2017

franzoni commented Feb 14, 2017

davidlange6 commented Feb 15, 2017

davidlange6 commented Feb 16, 2017

matz-e commented Feb 16, 2017

matz-e commented Feb 16, 2017

HCAL TP Geometry changes for plan1, phase2 #17469

HCAL TP Geometry changes for plan1, phase2 #17469

Conversation

matz-e commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

rekovic commented Feb 9, 2017

cmsbuild commented Feb 9, 2017 • edited

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

rekovic commented Feb 9, 2017

cmsbuild commented Feb 9, 2017 • edited

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

cmsbuild commented Feb 10, 2017

ianna commented Feb 10, 2017

cmsbuild commented Feb 10, 2017 • edited

cmsbuild commented Feb 10, 2017

cmsbuild commented Feb 10, 2017

cmsbuild commented Feb 10, 2017

ianna commented Feb 10, 2017

franzoni Feb 13, 2017

Choose a reason for hiding this comment

matz-e Feb 14, 2017

Choose a reason for hiding this comment

davidlange6 Feb 14, 2017

Choose a reason for hiding this comment

franzoni commented Feb 14, 2017

davidlange6 commented Feb 15, 2017

davidlange6 commented Feb 16, 2017

matz-e commented Feb 16, 2017

matz-e commented Feb 16, 2017

cmsbuild commented Feb 9, 2017 •

edited

cmsbuild commented Feb 9, 2017 •

edited

cmsbuild commented Feb 10, 2017 •

edited