L1TGlobalProducer: fix prescale index counting #17496
Conversation
The L1 prescale index should consistently count from 0 - this is the convention used by the L1 uGT, the monitoring code (e.g. WBM), etc. The previous version of the code was internally inconsistent: the value `m_prescaleSet-1` was being used to determine the prescales, but the value `m_prescaleSet` was set in the uGT payload.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_0_X. It involves the following packages: L1Trigger/L1TGlobal @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
fwyzard
force-pushed
the
L1TGlobalProducer_fix_prescale_index
branch
from
55d8992
to
1e6bdfd
Compare
|
please test |
|
The tests are being triggered in jenkins. |
|
@rekovic , can you backport this to CMSSW 8.0.x ? |
|
Also, the code in |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
The L1 prescale index should consistently count from 0 - this is the convention used by the L1 uGT, the monitoring code (e.g. WBM), etc.
The previous version of the code was internally inconsistent: the value
m_prescaleSet-1was being used to determine the prescales, but the valuem_prescaleSetwas set in the uGT payload.