Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation action for fakerate at high PU - HighPurity only #17504

Merged
merged 1 commit into from Feb 16, 2017

Conversation

ebrondol
Copy link
Contributor

@ebrondol ebrondol commented Feb 13, 2017

Some cuts in the triplets iterations have been applied in order to mitigate the fakerate in the HighPurity tracks collection keeping high the efficiency - even if it is getting a bit worse. This is not a definitive solution, of course.
I have presented the problem in the UPSG meeting.
Here reported the effect on the fakes for PU200: in red the fakes for 900pre2, in blue 819pre12 and in black 900pre2+PR.
screenshot from 2017-02-13 19-43-14
It should not affect timing significantly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebrondol for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17768/console Started: 2017/02/13 20:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@VinInn
Copy link
Contributor

VinInn commented Feb 14, 2017

Should not this be on top of #17228 ?

@ebrondol
Copy link
Contributor Author

@VinInn it is indipendent from the PR #17228

@slava77
Copy link
Contributor

slava77 commented Feb 14, 2017 via email

@ebrondol
Copy link
Contributor Author

@slava77 yes, please.

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

some plots from PU200

with just this PR:

  • ~4.5% reduction in charged hadrons (mostly pt<1 GeV) is the most visible change in higher level objects [track MTV and other indications point that these are mostly fakes]
    all_sign856vsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recopfcandidates_particleflow__reco_obj_eta43

compare this to the total generalTracks with fairly small changes
all_sign856vsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recotracks_generaltracks__reco_obj_eta
.. there are fewer shorter tracks
all_sign856vsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recotracks_generaltracks__reco_obj_found

This is the same for 17504+17228
all_sign856avsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recopfcandidates_particleflow__reco_obj_eta43

all_sign856avsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recotracks_generaltracks__reco_obj_eta

all_sign856avsorig_ttbar14tev2023d4timingpu200localwf23034p0c_recotracks_generaltracks__reco_obj_originalalgo

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

MTV fake rate for generalTracks looks only moderately better for pt>0.9 [this is a combination of 17504 and 17228]
wf23034_sign856avsorig_generalpt09_fake_eta

inclusively, it looks a bit better, but the pt>0.9 is probably more important
wf23034_sign856avsorig_general_fake_eta

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

Here is a set of other specialized MTV plots in combination with 17228:

wf23034_sign856avsorig_ak4pf_fake_eta

this is apparently matching also what goes to PF candidates, looks good

wf23034_sign856avsorig_btv_fake_eta

@makortel is the BtvLike selection actually correct? @arizzi @ferencek don't we use the PFCandidates by default now? So, I would expect the BtvLike to actually look more like the Pt09Hp plot below.

wf23034_sign856avsorig_hp09_fake_eta

If the issue in BtvLike is somewhat bogus, then we may be able to advance with this and 17228 PRs

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

Some plots for this PR alone, since it appears to be good to go be more ready to go by itself

wf23034_btv_fake_eta

the FR improvement in BtvLike looks good

wf23034_hp_eff_eta

There is a small efficiency loss in HP around eta~1. Are we OK with this?

@ebrondol
Copy link
Contributor Author

@slava77 we are awae of the loss of efficiency, but it seems a price to pay for now.

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017 via email

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

+1

for #17504 4281d3e

  • updated high purity selections for HighPtTriplet and LowPtTriplet Step in phase2
  • jenkins tests pass and comparisons with baseline show differences in 2023 workflows, (the stats are low, but differences are consistent with the change made and the plots posted in the PR descrition and local tests)
  • local tests with PU200 show roughly expected behavior, most visible in plots using tracks with high purity selection; Btag ROCs look good (below)
    • technical performance changes are minor (the reco time totals are within 0.5%)

Here are a couple of BTV plots with this PR alone
wf23034_csvv2_c_v_b
wf23034_mvav2_l_v_b
These look pretty good

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 33cc6f9 into cms-sw:CMSSW_9_0_X Feb 16, 2017
@slava77
Copy link
Contributor

slava77 commented Feb 16, 2017

Looking at 17504+17228

in PU200
(compare, e.g. https://cloud.githubusercontent.com/assets/4676718/22228971/9096d960-e189-11e6-9296-d817e246d18f.png)
the B-tagging performance is still better than the current baseline

wf23034_sign856avsorig_csvv2_c_v_b

wf23034_sign856avsorig_mvav2_l_v_b

So, I conclude that the MTV "BtvLike" plots are not really corresponding to the current default Btagging objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants