New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigation action for fakerate at high PU - HighPurity only #17504
Mitigation action for fakerate at high PU - HighPurity only #17504
Conversation
A new Pull Request was created by @ebrondol for CMSSW_9_0_X. It involves the following packages: RecoTracker/IterativeTracking @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Should not this be on top of #17228 ? |
On 2/14/17 1:25 AM, ebrondol wrote:
@VinInn <https://github.com/VinInn> it is indipendent from the PR #17228
<#17228>
I suppose, the point is to evaluate this PR performance in combination
with #17228
and if the combined looks OK to accept both.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17504 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbqHPlFj1drkTF81R70f8UjsHy-Yaks5rcXMDgaJpZM4L_oUc>.
|
@slava77 yes, please. |
Here is a set of other specialized MTV plots in combination with 17228: this is apparently matching also what goes to PF candidates, looks good @makortel is the BtvLike selection actually correct? @arizzi @ferencek don't we use the PFCandidates by default now? So, I would expect the BtvLike to actually look more like the Pt09Hp plot below.If the issue in BtvLike is somewhat bogus, then we may be able to advance with this and 17228 PRs |
@slava77 we are awae of the loss of efficiency, but it seems a price to pay for now. |
On 2/16/17 6:44 AM, ebrondol wrote:
@slava77 <https://github.com/slava77> we are awae of the loss of
efficiency, but it seems a price to pay for now.
OK
I'll sign this shortly.
For the 17228, I will need feedback on the notes in
#17504 (comment)
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17504 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcboZkE06ygAEwAuAOxdrypLiJvDk-ks5rdGDJgaJpZM4L_oUc>.
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Looking at 17504+17228 in PU200 So, I conclude that the MTV "BtvLike" plots are not really corresponding to the current default Btagging objects |
Some cuts in the triplets iterations have been applied in order to mitigate the fakerate in the HighPurity tracks collection keeping high the efficiency - even if it is getting a bit worse. This is not a definitive solution, of course.
I have presented the problem in the UPSG meeting.
Here reported the effect on the fakes for PU200: in red the fakes for 900pre2, in blue 819pre12 and in black 900pre2+PR.
It should not affect timing significantly.