Use edm::stream for ByMultiplicityEventFilter #17515
Conversation
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_0_X. It involves the following packages: DPGAnalysis/SiStripTools @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
-1 Tested at: 91d3f91 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/RecoTauTag/RecoTau/plugins/PFRecoTauCorrectedInvariantMassProducer.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/RecoTauTag/RecoTau/plugins/RecoTauElectronRejectionPlugin.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc: In instantiation of 'class ByMultiplicityEventFilter > >':
/cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-14-1100/src/FWCore/Framework/src/WorkerMaker.h:74:24: required from 'void edm::WorkerMaker::fillDescriptions(edm::ConfigurationDescriptions&) const [with T = ByMultiplicityEventFilter > >]'
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc:159:63: required from here
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc:128:1: error: 'void ByMultiplicityEventFilter::beginJob() [with T = SingleMultiplicity >]' marked 'override', but does not override
ByMultiplicityEventFilter::beginJob()
^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc:135:1: error: 'void ByMultiplicityEventFilter::endJob() [with T = SingleMultiplicity >]' marked 'override', but does not override
ByMultiplicityEventFilter::endJob() {
^
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/CondTools/Geometry/plugins/HcalParametersDBBuilder.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/CondTools/Geometry/plugins/calowriters.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/CondTools/Geometry/plugins/CSCRecoIdealDBLoader.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/CondTools/Geometry/plugins/PGeometricDetBuilder.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/CondTools/Geometry/plugins/ME0RecoIdealDBLoader.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc:57:20: error: 'beginJob' marked 'override' but does not override any member functions
virtual void beginJob() override ;
^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-14-1100/src/DPGAnalysis/SiStripTools/plugins/ByMultiplicityEventFilter.cc:59:20: error: 'endJob' marked 'override' but does not override any member functions
virtual void endJob() override ;
^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Pull request #17515 was updated. @cmsbuild, @monttj, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@monttj Can you please have a look and approve ASAP? Thanks! |
|
As long as all the template arguments are 'thread friendly' it appears to be fine. |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Update ByMultiplicityEventFilter to be an edm::stream module.