split CondCore/L1TPlugins/src/plugin.cc in smaller files #17548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_9_0_X. It involves the following packages: CondCore/L1TPlugins @ggovi, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Comparison job queued. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the one big plugin.cc file takes 22mins to compile on amd64 and over 2 hours on arm64. This Pr just breaks plugins.cc in to smallers pieces.
Resulting plugin contains every thing
diff -u <(grep pluginCondCoreL1TPlugins.so .edmplugincache) <(grep pluginCondCoreL1TPlugins.so /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_X_2017-02-16-2300/lib/slc6_amd64_gcc530/.edmplugincache)show no differences.