Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 Tracker with 12 Pixel Disks (v. 4025) [new WFs 2023D11] #17551

Merged
merged 9 commits into from Feb 21, 2017

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Feb 17, 2017

Greetings
This PR is introducing a new version of the phase2 tracker
The main change is the addition of a new disk in the forward pixel .

This geometry is now defining the tracker T5 and the workflow 2023D11 has been created (clone of the 2023D4 but with the new pixel ) - Scripts and documentations have been updated accordingly in this PR

Some link describing the geometry and the changes
http://ghugo.web.cern.ch/ghugo/layouts/merge/OT365_200_IT4025/
https://indico.cern.ch/event/536862/contributions/2397837/attachments/1384630/2106411/mersi_20161207_newlayouts.pdf

How to test :
Find the 2023D11 workflow in runthematrix , WFs 240XX

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_9_0_X.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @kpedro88, @franzoni, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ghugo83, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@boudoul
Copy link
Contributor Author

boudoul commented Feb 17, 2017

Most of the usual watchers are already there, adding @ebrondol , @atricomi , @delaere

@boudoul
Copy link
Contributor Author

boudoul commented Feb 17, 2017

please test with cms-data/SLHCUpgradeSimulations-Geometry#5

1 similar comment
@kpedro88
Copy link
Contributor

please test with cms-data/SLHCUpgradeSimulations-Geometry#5

@smuzaffar
Copy link
Contributor

testing only works with cmsdist PR :-) which is now available cms-sw/cmsdist#2836

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#2836

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 17, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2836
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17849/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b24f795

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17551/17849/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testPythonParameterSet had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@boudoul
Copy link
Contributor Author

boudoul commented Feb 20, 2017

seems that I forgot a file , fixing in a few minute

@cmsbuild
Copy link
Contributor

Pull request #17551 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @kpedro88, @franzoni, @hengne, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17889/console Started: 2017/02/21 09:47

@boudoul
Copy link
Contributor Author

boudoul commented Feb 20, 2017

thanks @kpedro88 , I have indeed updated with the missing file - so unhold from me (although I realized that I have no power on hold, unhold on github)

@ianna
Copy link
Contributor

ianna commented Feb 20, 2017

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@kpedro88
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants