Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate Materials #17569

Merged
merged 1 commit into from Feb 20, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 20, 2017

  • Use identical materials from trackermaterial namespace

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_9_0_X.

It involves the following packages:

Geometry/CMSCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @venturia, @VinInn, @ghugo83 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Feb 20, 2017

@veszpv - FYI

@ianna
Copy link
Contributor Author

ianna commented Feb 20, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17881/console Started: 2017/02/20 12:02

@civanch
Copy link
Contributor

civanch commented Feb 20, 2017

@ianna , I confirm that Geant4 warnings are fixed

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Feb 20, 2017

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8ee7db0 into cms-sw:CMSSW_9_0_X Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants