fix "improveWithTrack" for OT hit

[VinInn]

it was forgotten...
It surely affects refit, will affect standard tracking as well.

urgent bugfix

[VinInn]

type bugfix

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_9_0_X.

It involves the following packages:

DataFormats/TrackerRecHit2D

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @gpetruc this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17882/console Started: 2017/02/20 14:52

[VinInn]

@ebrondol

[VinInn]

@rovere

[cmsbuild]

+1
Tested at: b112983
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17571/17882/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17571/17882/summary.html

[cmsbuild]

Pull request #17571 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17893/console Started: 2017/02/21 09:48

[VinInn]

do not expect regression as Phase2 OT CPE does not yet make use of track angle...
At least is ready for the time when this will eventually happen.

Nevertherless the fix is needed for refit

[cmsbuild]

+1
Tested at: 3fe84b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17571/17893/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17571/17893/summary.html

[slava77]

+1

for #17571 3fe84b7

• implementation is in line with the description; as noted in fix "improveWithTrack" for OT hit #17571 (comment) the current tracking setup for phase-2 is not using the affected feature and no changes are expected in standard workflows.
• jenkins tests pass and comparisons with baseline show no differences

this apparently fixes the problem reported in
https://hypernews.cern.ch/HyperNews/CMS/get/recoTracking/1672/1/1/2/1/1/1/1/1.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1