Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve missing-braces error (GCC 7, C++17) #17611

Merged
merged 1 commit into from Feb 24, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 22, 2017

This is same issue as here: 7d049b8

See #17426

This showed up in slc7_aarch64_gcc700 build.

Signed-off-by: David Abdurachmanov davidlt@cern.ch

This is same issue as here: 7d049b8

Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Feb 22, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17931/console Started: 2017/02/23 05:14
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17935/console Started: 2017/02/23 12:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 23, 2017

+1

for #17611 5ea47c0

  • technical change in DataFormats/Math/interface/ExtVec.h; as described
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e6292e3 into cms-sw:CMSSW_9_0_X Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants