Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup for SIM #17670

Merged
merged 1 commit into from Mar 2, 2017
Merged

Some cleanup for SIM #17670

merged 1 commit into from Mar 2, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 1, 2017

Few fixes which are not relevant to mainstream production:

  1. Dump of gdml has a slightly new interface in Geant4 10.2 - modifications are verified by check of consumers of CMS gdml
  2. Added extra possibility to dump gdml via Physical Volume name
  3. Fixed few static analysis warnings

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_9_0_X.

It involves the following packages:

SimG4Core/Application
SimG4Core/CustomPhysics
SimG4Core/Geometry
SimG4Core/PrintGeomInfo

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor Author

civanch commented Mar 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18031/console Started: 2017/03/01 16:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

Comparison job queued.

@civanch
Copy link
Contributor Author

civanch commented Mar 1, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b2ebd22 into cms-sw:CMSSW_9_0_X Mar 2, 2017
@cmsbuild cmsbuild mentioned this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants