Pfmuon fix 90x

[cmsbuild]

low tight and loose muon ID efficiency due to low pfmuon efficiency due to GeneralTracksImporterWithVeto killing pftracks
This issue was noticed in #16797
pfmuon temp fix - hgcal will fix later

fix rotation in me0geometry - in me0 even and odd chambers are not inverted

@calabria @lgray @pietverwilligen @kpedro88
Automatically ported from CMSSW_9_0_X #17648 (original by @jshlee).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Geometry/GEMGeometryBuilder
RecoParticleFlow/PFProducer

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @rafaellopesdesa, @lgray, @cbernet, @bachtis this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18053/console Started: 2017/03/02 14:57

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18071/console Started: 2017/03/02 15:52

[slava77]

-1

I think this should be split in two (ME0 geometry removed from this PR)

[cmsbuild]

Pull request #17703 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18565/console Started: 2017/03/20 19:58

[cmsbuild]

Pull request #17703 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: 47865c8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17703/18565/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17703/18565/summary.html

[slava77]

In TenMuExtendedE 2023D4 wf 21211

There is an expected "reassignment" of muons from |eta|>2.5 to be charged hadrons.
There is also some reduction in pf muons in |eta|<2.5
Given the improvements in ID, I'm guessing that the reduction in pfMus is from some duplicates

MET is still better in this sample, which reaffirms that the changes are overall in good direction for muons

In 23034 with PU200:


This seems somewhat in line with #17703 (comment)

jet response, MET, and b-tags appear to behave essentially the same in this sample with PU (areas where earlier iterations looked problematic).

Technical performance: timing total has a moderate increase of about 1% (from 609 to 618 s/event), coming out from quite a few ups and downs (like particleFlowBlock time up by 30% from 1.9 to 2.6 s/evt)

Memory is roughly unchanged with PU200 (there is an apparent increase of 15MB/core over 8GB/core in the test job).

[slava77]

+1

for #17703 47865c8

• code changes are roughly in line with the needed modifications here Pfmuon fix 90x #17703 (comment): in HGCAL-related reco the tracks related to muons are imported in a special way that doesn't kill muon PF ID
  • unfortunately due to auto-fwd port, this PR description can not be edited by the original submitter.
• jenkins tests pass and comparisons show differences only in "C2 (HGCAL)"-related workflows D4 and D8 with changes related to PF muons and hadrons and downstream quantities
• local tests confirm the expected behavior (see Pfmuon fix 90x #17703 (comment) and Pfmuon fix 90x #17703 (comment))

[slava77]

release-note: recover PF muon efficiency in workflows with HGCAL

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1