Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TrackerSeedValidator as obsolete #17744

Merged
merged 1 commit into from Mar 5, 2017
Merged

Remove TrackerSeedValidator as obsolete #17744

merged 1 commit into from Mar 5, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 2, 2017

This PR removes TrackerSeedValidator as it has been obsoleted (long time ago) by TrackFromSeedProducer+MultiTrackValidator, as configured in
TrackValidation_cff.py for trackingOnly mode.

Tested in 9_0_0_pre4, no changes expected in standard workflows.

@rovere @VinInn

@makortel
Remove TrackerSeedValidator as obsolete
cb55365 
For a long time the preferred method for seed validation plots has
been TrackFromSeedProducer+MultiTrackValidator, as configured in
TrackValidation_cff.py for trackingOnly mode.
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 2, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FastSimulation/Validation
Validation/RecoTrack

@civanch, @lveldere, @ssekmen, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @wmtford, @matt-komm, @mtosi, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor Author

makortel commented Mar 3, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18130/console Started: 2017/03/03 15:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

+1
Tested at: cb55365
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17744/18130/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17744/18130/summary.html

@davidlange6 davidlange6 merged commit 0ed1f2a into cms-sw:master Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-pending fastsim-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makortel @cmsbuild @davidlange6