Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch phase1 tracking to use CA seeding by default #17766

Merged
merged 1 commit into from Mar 14, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 3, 2017

This PR switches the phase1 tracking to use the CA seeding by default (effectively reverting the last commit of #16911). The current default seeding is kept in special workflows (using the same workflow numbers as the special CA workflows had before).

Here are MTV plots comparing CA seeding to the current default with 1000 ttbar+35PU events in 900pre4+#17537+#17511+#17544 (which should correspond to 900pre5 for tracking)
https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_9_0_0_pre4_phase1ca/
Here are also some b tagging performance plots from the same events
https://cms-btag-validation.web.cern.ch/cms-btag-validation/CA-tracking900pre4/plots123/
(thanks to @JyothsnaKomaragiri)

Tested in CMSSW_9_1_X_2017-03-02-2300, expecting changes like above in phase1 workflows, no changes expected in phase0/2.

@rovere @VinInn @felicepantaleo @ebrondol

@makortel
Copy link
Contributor Author

makortel commented Mar 3, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18129/console Started: 2017/03/03 14:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences

@kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 3, 2017

@makortel
please share the DQM*.root files used in the comparisons. (email, maybe)
Thank you.

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@fabozzi
Copy link
Contributor

fabozzi commented Mar 6, 2017

+1

@davidlange6
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2017

+1

for #17766 deed766

  • configuration changes to switch the default 2017 tracking to use CA, in line with the description
  • jenkins tests pass and comparisons with baseline show differences only in 2017/2018 workflows
  • supplied plots show improved or consistent behavior
    • MTV plots show roughly the same fake rate, while the efficiency is up significantly at low pt, below 0.3 GeV
    • B-tagging ROC plots show consistent behavior (the previously observed issue with loss of efficiency is gone; IIRC, a part was mitigated directly, a part may have been a fluctuation, and a part is resolved by updates in MVA HP track selections)
  • local tests confirm behavior in ttbar PU supplied with the PR; total CPU time in reco is down by ~3.5%

Here are some highlights (baseline = CMSSW_9_1_X_2017-03-09-1100)

the most striking feature is the large increase in tracks with pT below 0.3GeV (plots from TTbar PU35)
all_sign875vsorig_ttbar13tevpu2017wf10224p0c_log10recotracks_generaltracks__reco_obj_pt

this is also visible in pf charged hadrons:
all_sign875vsorig_ttbar13tevpu2017wf10224p0c_log10recopfcandidates_particleflow__reco_obj_pt45

This matches the increase in efficiency at low PT (see supplied MTV plots)
e.g.
wf10224matti_general_eff_vs_fakedup
and there are no significant indications of fake contribution here at low pt.

The population if short tracks is up quite a bit
all_sign875vsorig_ttbar13tevpu2017wf10224p0c_recotracks_generaltracks__reco_obj_found

The electronMergedSeeds are now mostly 4-hits
all_sign875vsorig_ttbar13tevpu2017wf10224p0c_recoelectronseeds_electronmergedseeds__reco_obj_nhits

========

B-tagging plots in https://cms-btag-validation.web.cern.ch/cms-btag-validation/CA-tracking900pre4/plots123/ look consistent with CA and with the old baseline. This was the main show-stopper in the earlier attempt to switch to CA and it is gone now.

========

Technical performance in 10224:

  • CPU time goes down, by about 9% in the iterative tracking modules; the total RECO+miniAOD time is down by about 3.5% (from 16.7 s/evt to 16.1 s/evt)
  • (post-event) RSS memory maximum is down by 80MB. This measurement is not particulalry precise, but gives an indication of no increase
  • file size on disk increases moderately (miniAOD size up by ~0.8% on 100 events file) driven by increase in low-pt tracks/charged hadrons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants