Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add differential pulls, and resolutions+pulls for PV to vertex validation #17787

Merged
merged 5 commits into from Mar 7, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 6, 2017

This PR updates the vertex validation in the following way

  • Adjust "merge rate vs. closest vertex in z" x axis range to have uniform bin width when drawn with logarithmic x axis, and extend the minimum to 1e-4 cm
  • Add pulls vs. number of tracks, PU, z, and sum(pT)
  • Add resolution and pull plots for the PV
    • only for events where the reco PV is correctly identified
    • regardless if the PV is a merged vertex or not (to remind, for all vertices the plots are separate for non-merged and merged vertices)

Tested in 9_0_0_pre4, in addition of added histograms expecting changes in the merge rate vs. closest vertex in z histogram.

@rovere @VinInn @ebrondol

@makortel
Copy link
Contributor Author

makortel commented Mar 6, 2017

@cmsbuild, please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18154/console Started: 2017/03/06 10:56

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Validation/RecoVertex

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mtosi, @dgulhan, @venturia this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@ebrondol
Copy link
Contributor

ebrondol commented Mar 6, 2017

Thanks @makortel !
Is it going to also "solve" what we discussed about the x min of merged vtx for Phase2, right?

@makortel
Copy link
Contributor Author

makortel commented Mar 6, 2017

@ebrondol

Is it going to also "solve" what we discussed about the x min of merged vtx for Phase2, right?

Yes (this is the first bullet of the description).

@ebrondol
Copy link
Contributor

ebrondol commented Mar 6, 2017

Exactly, great.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 418b035 into cms-sw:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants