Converted BaseEvtVtxGenerator to stream module #17813

Dr15Jones · 2017-03-07T22:04:39Z

Measurements of GEN+SIM steps with large number of threads showed the vertex generator used was stalling. This converts all the vertex generators inheriting from BaseEvtVtxGenerator into stream modules.

The arguments of the member functions are not meant to be modified so they should be const.

In addition to making BaseEvtVtxGenerator a stream module, the virtual functions of the class were changed to be const. This was originally done in an attempt to make the module a global module. That was abandoned since some base classes were using beginRun to read from the EventSetup and set their parameters (which could be done using RunCache but would complicate the design). The member functions were kept const since I believe they allowed the implementation to be better.

cmsbuild · 2017-03-07T22:04:57Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

IOMC/EventVertexGenerators
SimDataFormats/GeneratorProducts

@civanch, @perrozzi, @mdhildreth, @cmsbuild, @thuer, @govoni, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Dr15Jones · 2017-03-07T22:08:59Z

please test

cmsbuild · 2017-03-07T22:09:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18232/console Started: 2017/03/07 23:10

cmsbuild · 2017-03-07T23:53:54Z

-1

Tested at: b382d85

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17813/18232/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step1

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

10021.0 step1

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step1

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Mar 8 00:40:52 2017-date Wed Mar 8 00:40:07 2017 s - exit: 22016
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Wed Mar 8 00:42:48 2017-date Wed Mar 8 00:40:18 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:42:48 2017-date Wed Mar 8 00:40:18 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:42:48 2017-date Wed Mar 8 00:40:18 2017 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Wed Mar 8 00:41:06 2017-date Wed Mar 8 00:40:20 2017 s - exit: 22016
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:40:25 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:40:25 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:40:25 2017 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Wed Mar 8 00:41:41 2017-date Wed Mar 8 00:40:27 2017 s - exit: 22016
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:41:03 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:41:03 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:41:48 2017-date Wed Mar 8 00:41:03 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Wed Mar 8 00:43:01 2017-date Wed Mar 8 00:41:08 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:43:01 2017-date Wed Mar 8 00:41:08 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:43:01 2017-date Wed Mar 8 00:41:08 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Wed Mar 8 00:43:38 2017-date Wed Mar 8 00:41:49 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:43:38 2017-date Wed Mar 8 00:41:49 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:43:38 2017-date Wed Mar 8 00:41:49 2017 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Wed Mar 8 00:46:52 2017-date Wed Mar 8 00:43:02 2017 s - exit: 22016
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-07-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 8 00:46:52 2017-date Wed Mar 8 00:43:02 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Wed Mar 8 00:46:52 2017-date Wed Mar 8 00:43:02 2017 s - exit: 21504

cmsbuild · 2017-03-07T23:53:57Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-03-08T16:30:42Z

Pull request #17813 was updated. @civanch, @perrozzi, @mdhildreth, @cmsbuild, @thuer, @govoni, @davidlange6 can you please check and sign again.

Dr15Jones · 2017-03-08T16:39:40Z

please test

cmsbuild · 2017-03-08T16:39:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18248/console Started: 2017/03/08 17:41

cmsbuild · 2017-03-08T19:16:22Z

+1
Tested at: 46e1d48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17813/18248/summary.html

cmsbuild · 2017-03-08T19:16:24Z

Comparison job queued.

cmsbuild · 2017-03-08T21:49:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17813/18248/summary.html

civanch · 2017-03-09T11:11:27Z

@Dr15Jones , in BetafuncEvtVtxGenerator::setBoost(...) sin(), cos(), tan() multiply computed for the same arguments. You think, the compiler will optimise this or may be some optimisation should be added manually?

Dr15Jones · 2017-03-09T15:35:44Z

@civanch I'm pretty sure the compiler can't optimise the calls since it would not know if the functions have side-effects. However, given the function is only called at beginLuminosityBlock and for all GEN+SIM jobs that happens only once, it probably is not worth optimizing.

civanch · 2017-03-09T15:53:05Z

+1

Dr15Jones · 2017-03-14T16:07:03Z

ping

perrozzi · 2017-03-14T16:43:56Z

+1

cmsbuild · 2017-03-14T16:44:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

davidlange6 · 2017-03-14T17:38:00Z

+1

Dr15Jones added 2 commits March 7, 2017 15:53

Pass values to member functions of HepMCProduct as const

537ef4d

The arguments of the member functions are not meant to be modified so they should be const.

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 7, 2017

cmsbuild added comparison-pending generators-pending orp-pending pending-signatures simulation-pending tests-pending labels Mar 7, 2017

Added missing const and override

b382d85

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 7, 2017

Must initialize TMatrixD to proper size in constructor

46e1d48

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Mar 8, 2017

cmsbuild removed the tests-pending label Mar 8, 2017

cmsbuild added the tests-started label Mar 8, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 8, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 8, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Mar 9, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Mar 14, 2017

cmsbuild added orp-approved and removed orp-pending labels Mar 14, 2017

cmsbuild merged commit afa1a7c into cms-sw:master Mar 14, 2017

Dr15Jones deleted the streamEvtVtxGenerator branch March 15, 2017 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted BaseEvtVtxGenerator to stream module #17813

Converted BaseEvtVtxGenerator to stream module #17813

Dr15Jones commented Mar 7, 2017

cmsbuild commented Mar 7, 2017

Dr15Jones commented Mar 7, 2017

cmsbuild commented Mar 7, 2017 •

edited

cmsbuild commented Mar 7, 2017

cmsbuild commented Mar 7, 2017

cmsbuild commented Mar 8, 2017

Dr15Jones commented Mar 8, 2017

cmsbuild commented Mar 8, 2017 •

edited

cmsbuild commented Mar 8, 2017

cmsbuild commented Mar 8, 2017

cmsbuild commented Mar 8, 2017

civanch commented Mar 9, 2017

Dr15Jones commented Mar 9, 2017

civanch commented Mar 9, 2017

Dr15Jones commented Mar 14, 2017

perrozzi commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

davidlange6 commented Mar 14, 2017

Converted BaseEvtVtxGenerator to stream module #17813

Converted BaseEvtVtxGenerator to stream module #17813

Conversation

Dr15Jones commented Mar 7, 2017

cmsbuild commented Mar 7, 2017

Dr15Jones commented Mar 7, 2017

cmsbuild commented Mar 7, 2017 • edited

cmsbuild commented Mar 7, 2017

cmsbuild commented Mar 7, 2017

cmsbuild commented Mar 8, 2017

Dr15Jones commented Mar 8, 2017

cmsbuild commented Mar 8, 2017 • edited

cmsbuild commented Mar 8, 2017

cmsbuild commented Mar 8, 2017

cmsbuild commented Mar 8, 2017

civanch commented Mar 9, 2017

Dr15Jones commented Mar 9, 2017

civanch commented Mar 9, 2017

Dr15Jones commented Mar 14, 2017

perrozzi commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

davidlange6 commented Mar 14, 2017

cmsbuild commented Mar 7, 2017 •

edited

cmsbuild commented Mar 8, 2017 •

edited