Restructure XML Data Directories by Year and Version Step 2 #17844
Conversation
renamed: Geometry/MuonCommonData/data/v2/csc.xml -> Geometry/MuonCommonData/data/csc/2015/v1/csc.xml renamed: Geometry/MuonCommonData/data/v2/mfshield.xml -> Geometry/MuonCommonData/data/mfshield/2015/v1/mfshield.xml new file: Geometry/MuonCommonData/data/mfshield/2017/v1/mfshield.xml renamed: Geometry/MuonCommonData/data/PhaseII/mfshield.xml -> Geometry/MuonCommonData/data/mfshield/2023/v1/mfshield.xml renamed: Geometry/MuonCommonData/data/v2/muonNumbering.xml -> Geometry/MuonCommonData/data/muonNumbering/2015/v1/muonNumbering.xml renamed: Geometry/MuonCommonData/data/v6/muonGemNumbering17.xml -> Geometry/MuonCommonData/data/muonNumbering/2017/v1/muonNumbering.xml renamed: Geometry/MuonCommonData/data/v6/muonGemNumbering.xml -> Geometry/MuonCommonData/data/muonNumbering/2019/v1/muonGemNumbering.xml renamed: Geometry/MuonCommonData/data/v2/rpcf.xml -> Geometry/MuonCommonData/data/rpcf/2015/v1/rpcf.xml renamed: Geometry/MuonCommonData/data/PhaseII/rpcf.xml -> Geometry/MuonCommonData/data/rpcf/2023/v1/rpcf.xml deleted: Geometry/MuonCommonData/data/v2/muonGemNumbering.xml
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Comparison job queued. |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
@davidlange6 - If you have any objections against integrating this PR, please, list them here. It would be good to put at least one IB between it and further modifications. |
|
will try to catch up today on this and the other related PR..
… On Mar 10, 2017, at 9:26 AM, Ianna Osborne ***@***.***> wrote:
@davidlange6 - If you have any objections against integrating this PR, please, list them here. It would be good to put at least one IB between it and further modifications.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 - thanks! |
|
@davidlange6 - Please, list your objections for this PR integration here so that I could address them. Thanks. |
|
+1 |
|
just had not gotten to it.. |
This PR is based on fully signed and tested #17831
In addition it integrates GE11 overlap fix from #17830 in a new directory structure.
rename Geometry/MuonCommonData/data/{v2 => csc/2015/v1}/csc.xml (100%)
rename Geometry/MuonCommonData/data/{v2 => mfshield/2015/v1}/mfshield.xml (100%)
create mode 100644 Geometry/MuonCommonData/data/mfshield/2017/v1/mfshield.xml
rename Geometry/MuonCommonData/data/{PhaseII => mfshield/2023/v1}/mfshield.xml (100%)
rename Geometry/MuonCommonData/data/{v2 => muonNumbering/2015/v1}/muonNumbering.xml (100%)
rename Geometry/MuonCommonData/data/{v6/muonGemNumbering17.xml => muonNumbering/2017/v1/muonNumbering.xml} (100%)
rename Geometry/MuonCommonData/data/{v6 => muonNumbering/2019/v1}/muonGemNumbering.xml (100%)
rename Geometry/MuonCommonData/data/{v2 => rpcf/2015/v1}/rpcf.xml (100%)
rename Geometry/MuonCommonData/data/{PhaseII => rpcf/2023/v1}/rpcf.xml (100%)
delete mode 100644 Geometry/MuonCommonData/data/v2/muonGemNumbering.xml