Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HLT STORM validation to Phase1 (90X) #17853

Merged
merged 11 commits into from
Mar 13, 2017
Merged

Update HLT STORM validation to Phase1 (90X) #17853

merged 11 commits into from
Mar 13, 2017

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Mar 9, 2017 •
edited

Backport of #17852

This PR is a general update of the HLT menu validation to Phase1.
It includes:

  • update of the HLT menus to Phase1 (ie. confDB /dev/CMSSW_9_0_1/)
  • clean up of PIon and HIon menus, as accorded with HI people
  • clean up of modifyHLTforEras
  • add of GRun2016 to test the 2016 menu. Currently it is the /dev/CMSSW_9_0_0/ menu. It will become GRun + reverse customization function, as soon as the function will be ready
  • update of the symbolic update to use the 'phase1_2017_realistic'
  • update of the input files/eras to run the phase1 menu
  • add 'HLT:@relval2017' cmsDriver option to peak the 2017 HLT menu and use it for the phase-1 relval production
  • changes in HLT addOnTests:
    • add validation of GRun2016
    • change Era from Run_2016 to Run_2017, except for GRun2016

Open issues:

Based on CMSSW_9_0_X_2017-03-08-1100.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Mar 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_9_0_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @geoff-smith, @jalimena, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18281/console Started: 2017/03/09 13:53

@silviodonato silviodonato mentioned this pull request Mar 9, 2017
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Pull request #17853 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18284/console Started: 2017/03/09 15:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

-1

Tested at: 6ae229d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
774355b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18284/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18284/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18284/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Mar 9 15:56:45 2017-date Thu Mar 9 15:50:46 2017 s - exit: 16640
cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-03-08-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 9 16:01:54 2017-date Thu Mar 9 15:50:52 2017 s - exit: 34304
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Mar 9 15:56:47 2017-date Thu Mar 9 15:51:34 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Mar 9 16:04:14 2017-date Thu Mar 9 15:57:21 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
774355b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18284/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18284/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

+1
Tested at: b9c49aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18331/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6f15efd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18331/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18331/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17853/18331/summary.html

@fabozzi
Copy link
Contributor

fabozzi commented Mar 10, 2017

+1

@kpedro88
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e4dc89f into cms-sw:CMSSW_9_0_X Mar 13, 2017
@Martin-Grunewald Martin-Grunewald mentioned this pull request Mar 13, 2017
Merged
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Mar 14, 2017
@fwyzard
backport cms-sw#17853
79b15b3
@davidlange6 davidlange6 mentioned this pull request Mar 24, 2017
Closed
@Martin-Grunewald Martin-Grunewald deleted the PhaseIHLTvalidation branch July 7, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available core-approved fully-signed hlt-approved orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@silviodonato @cmsbuild @Martin-Grunewald @fabozzi @kpedro88 @Dr15Jones @davidlange6