New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::unique_ptr to manage memory in PileupJetIdProducer #17863
Use std::unique_ptr to manage memory in PileupJetIdProducer #17863
Conversation
While fixing a memory leak also switched from bare pointers to using std::unique_ptr.
please test |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoJets/JetProducers @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: |
ping |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
While fixing a memory leak also switched from bare pointers to
using std::unique_ptr.