Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::unique_ptr to manage memory in PileupJetIdProducer #17863

Merged

Conversation

Dr15Jones
Copy link
Contributor

While fixing a memory leak also switched from bare pointers to
using std::unique_ptr.

While fixing a memory leak also switched from bare pointers to
using std::unique_ptr.
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 9, 2017
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @rappoccio, @yslai, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18304/console Started: 2017/03/09 20:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17863/18304/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@Dr15Jones
Copy link
Contributor Author

ping

@slava77
Copy link
Contributor

slava77 commented Mar 15, 2017

+1

for #17863 98ac7fe

  • implemented as described
  • jenkins tests pass and comparisons show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 838f8b2 into cms-sw:master Mar 16, 2017
@Dr15Jones Dr15Jones deleted the fixMemoryLeakInPileupJetIdProducer branch March 30, 2017 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants