Sistrip cluster gain/raw cluster charge update - 91X #17865
Conversation
|
A new Pull Request was created by @enochnotsocool (Enoch Chen) for master. It involves the following packages: DQM/SiStripMonitorTrack @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| edm::EDGetTokenT<edmNew::DetSetVector<SiStripCluster> > clusterToken_; | ||
| edm::EDGetTokenT<reco::TrackCollection> trackToken_; | ||
|
|
||
| edm::Handle<edm::DetSetVector<SiStripDigi>> digiHandle_; |
There was a problem hiding this comment.
can this become a function-local variable rather than a class member?
There was a problem hiding this comment.
Potentially yes.
The reason it is currently implemented as a class member is that since the function where it is actually uses is rather deep in the various methods called by the analyze() method, so initializing it where it is used or passing it though the method calls would require quite a larger alterations to the code.
There was a problem hiding this comment.
But that's part of the point...
Since it is a class member it makes it incredibly easy to misuse (ie outside analyze),
the fact you have a very complex call tree makes it even easier.
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #17865 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #17865 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
trackStudyFromTrajectory()instead oftrackStudyFromTrack().