Fix for JPTFastjet correction chains #17900

kodolova · 2017-03-13T08:45:59Z

Correction of the L1Fstajet correction for JPT

cmsbuild · 2017-03-13T08:46:13Z

A new Pull Request was created by @kodolova (kodolova) for master.

It involves the following packages:

JetMETCorrections/Configuration

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

perrotta · 2017-03-13T09:07:25Z

@kodolova please edit the PR title to include explicitly the description of the fix

slava77 · 2017-03-13T14:03:06Z

@cmsbuild please test

cmsbuild · 2017-03-13T14:03:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18363/console Started: 2017/03/13 19:17

cmsbuild · 2017-03-13T19:28:28Z

-1

Tested at: 9354882

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17900/18363/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8.log

cmsbuild · 2017-03-13T19:28:29Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

…L1L2L3. JPT needs CaloL1Offset and CaloL1Fastjet at the Level 1 corrections.

cmsbuild · 2017-03-13T20:11:29Z

Pull request #17900 was updated. @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please check and sign again.

kodolova · 2017-03-13T20:11:40Z

Made change in JetMETCorrections/Configuration/python/JetCorrectorsAllAlgos_cff.py
There was an artefact with ak7JPTL1OffsetCorrector. Changed to ak7CaloL1OffsetCorrector.

slava77 · 2017-03-13T20:22:57Z

@cmsbuild please test

kodolova · 2017-03-14T18:37:33Z

Correct me if I am wrong. This error has nothing to do with JetMETCorrections/Configuration.
An exception of category 'FatalRootError' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'pathALCARECOMuAlZMuMuGeneralTracks'
[2] Calling method for module TrackingMonitor/'ALCARECOMuAlZMuMuGeneralTracksTrackingDQM'
Additional Info:
[a] Fatal Root Error: @sub=TClingCallFunc::make_wrapper
Failed to compile

slava77 · 2017-03-14T19:16:56Z

@cmsbuild please test

error in 25.0 is apparently transient.

cmsbuild · 2017-03-14T19:17:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18429/console Started: 2017/03/14 22:53

cmsbuild · 2017-03-14T23:44:47Z

+1
Tested at: e85723d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17900/18429/summary.html

cmsbuild · 2017-03-14T23:44:49Z

Comparison job queued.

cmsbuild · 2017-03-15T02:18:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17900/18429/summary.html

perrotta · 2017-03-18T08:02:46Z

@kodolova could you please attach here the address of a presentation (group meeting or anywhere else) in which the effect of this "bug fix" was shown and/or discussed?
Could you please also edit the title of this PR and modify it into something more descriptive, so that it will be more easily identified in the list of the PRs integrated in CMSSW?

kodolova · 2017-03-18T14:53:23Z

There is a PAS that shows how to use L1Offset/Fastjet for JPT:https://cms.cern.ch/iCMS/analysisadmin/get?analysis=JME-14-005-pas-v30.pdf (page 3). L1JPTFastjet corrections should be done in the same way as L1JPTOffset. Otherwise it does not pickup ZSP corrections for JPT.

kodolova · 2017-03-18T14:54:27Z

I renamed to L1JPTFastjetFix.

slava77 · 2017-03-18T14:58:15Z

On 3/18/17 7:54 AM, kodolova wrote: I renamed to L1JPTFastjetFix.

A grammatically correct title in plain English would be nice. Thank you.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17900 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcboFQqPJhrEfuPv-HgSEGLMsHs8ZMks5rm_AkgaJpZM4Ma-iN>.

monttj · 2017-03-19T13:25:23Z

JetMETCorrections/Configuration/python/JetCorrectors_cff.py

+    )
+ak4L1JPTFastjetCorrectorChain = cms.Sequence(
+    ak4CaloL1FastjetCorrector * ak4L1JPTFastjetCorrector
+)


@kodolova

I am wondering if this sequence is really used somewhere?
"ak4L1JPTFastjetCorrectorChain"

Regards,
Taejeong

kodolova · 2017-03-19T13:36:26Z

This is the sequence for L1JPTFastjet corrections. Please, look to CorrectedJetProducers_cff.py
ak4JPTJetsL1 = cms.EDProducer(
'CorrectedJPTJetProducer',
src = cms.InputTag('JetPlusTrackZSPCorJetAntiKt4'),
correctors = cms.VInputTag('ak4L1JPTFastjetCorrector')
)
This is the correct producer for L1JPTFastjet offset.

perrotta · 2017-03-27T08:30:00Z

@kodolova : this PR does not merge any more: could you please rebase and/or update it?
Furthermore: do you have any plot that shows the expected changes because of the fix implemented here? Or can you tell us what would you actually expect?

kodolova · 2017-03-29T14:16:08Z

The reason of change is that JPTjets have the L1 corrections in two steps: firstly Calojets (part of JPTjet) are corrected for L1Offset or L1Fastjet and then corrections for zero suppression is done. Currently it is correctily implemented only for L1Offset. For chains that includes CaloL1Fastjet, zsp corrections are missed and this is 20% of jet energy scale.
Concerning rebase/update, I see that Configuration is completely changed. Thus, this is not a matter of rebase. I sent message to JetMET conveners and ask how to proceed.

kodolova · 2017-03-29T15:47:06Z

I am closing this PR and open the new one.

kodolova · 2017-03-29T15:49:49Z

The new PR is 18121

kodolova added 3 commits March 13, 2017 09:41

Bug fix for JPT L1Fastjet

d147647

Bug fix for JPT L1Fastjet

4ab1fe9

Bug fix for JPT L1Fastjet

9354882

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 13, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 13, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 13, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 13, 2017

Change ak7JPTL1OffsetCorrector to ak7CaloL1OffsetCorrector for ak7JPT…

65b7935

…L1L2L3. JPT needs CaloL1Offset and CaloL1Fastjet at the Level 1 corrections.

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Mar 13, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Mar 14, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 15, 2017

kodolova changed the title ~~JPTJECbugfixV2~~ L1JPTFastjetFix Mar 18, 2017

kodolova changed the title ~~L1JPTFastjetFix~~ Fix for JPTFastjet correction chains Mar 18, 2017

monttj reviewed Mar 19, 2017

View reviewed changes

kodolova closed this Mar 29, 2017

perrotta mentioned this pull request Apr 4, 2017

Fix for JPTFastjet correction chains #18121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for JPTFastjet correction chains #17900

Fix for JPTFastjet correction chains #17900

kodolova commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

perrotta commented Mar 13, 2017

slava77 commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 •

edited

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

kodolova commented Mar 13, 2017

slava77 commented Mar 13, 2017

kodolova commented Mar 14, 2017

slava77 commented Mar 14, 2017

cmsbuild commented Mar 14, 2017 •

edited

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 15, 2017

perrotta commented Mar 18, 2017

kodolova commented Mar 18, 2017

kodolova commented Mar 18, 2017

slava77 commented Mar 18, 2017 via email

monttj Mar 19, 2017

kodolova commented Mar 19, 2017

perrotta commented Mar 27, 2017

kodolova commented Mar 29, 2017

kodolova commented Mar 29, 2017

kodolova commented Mar 29, 2017

Fix for JPTFastjet correction chains #17900

Fix for JPTFastjet correction chains #17900

Conversation

kodolova commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

perrotta commented Mar 13, 2017

slava77 commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 • edited

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

kodolova commented Mar 13, 2017

slava77 commented Mar 13, 2017

kodolova commented Mar 14, 2017

slava77 commented Mar 14, 2017

cmsbuild commented Mar 14, 2017 • edited

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 15, 2017

perrotta commented Mar 18, 2017

kodolova commented Mar 18, 2017

kodolova commented Mar 18, 2017

slava77 commented Mar 18, 2017 via email

monttj Mar 19, 2017

Choose a reason for hiding this comment

kodolova commented Mar 19, 2017

perrotta commented Mar 27, 2017

kodolova commented Mar 29, 2017

kodolova commented Mar 29, 2017

kodolova commented Mar 29, 2017

cmsbuild commented Mar 13, 2017 •

edited

cmsbuild commented Mar 14, 2017 •

edited