Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[91X] fix ShallowEventDataProducer to allow running SiStripGain PCL producers from 2016 ALCARECO #17981

Merged
merged 2 commits into from Mar 21, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 18, 2017

Greetings,
this PR fixes the problem introduced in #17570, which unfortunately breaks the mode in which ALCA:PromptCalibProdSiStripGainsAfterAbortGap is invoked to run on existing ALCARECO datasets (e.g. 2016 ones) that don't have the LumiScalers collection. At present:

cmsDriver.py step3 --datatier ALCARECO --conditions auto:run2_data -s ALCA:PromptCalibProdSiStripGainsAfterAbortGap --eventcontent ALCARECO --runUnscheduled --process ALCAPROMPT --data -n 100 --dasquery='file dataset=/StreamExpress/Run2016H-SiStripCalMinBiasAfterAbortGap-Express-v2/ALCARECO run=282917' --fileout file:step3.root

fails with:

----- Begin Fatal Exception 18-Mar-2017 10:32:06 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 282917 lumi: 119 event: 63362406
   [1] Running path 'pathALCARECOPromptCalibProdSiStripGainsAfterAbortGap'
   [2] Prefetching for module SiStripGainFromCalibTree/'ALCARECOSiStripCalibAfterAbortGap'
   [3] Calling method for module ShallowEventDataProducer/'ALCARECOShallowEventRunAAG'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<LumiScalers>
Looking for module label: scalersRawToDigi
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

This running mode (which is NOT the one used at Tier-0) is anyway needed for large statistics study in view of improving the monitoring for 2017.

After internal discussions, in the same PR we propose to add LumiScalers and DcsStatus collections also in the SiStripCalMinBiasAfterAbortGap ALCARECO (as it was done for regular SiStripCalMinBias in #17419) an effective increase of ~135b/evt.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripCommon
Calibration/TkAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @mverzett, @threus, @jlagram this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Mar 18, 2017

attn: @dimattia

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18550/console Started: 2017/03/19 17:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@arunhep
Copy link
Contributor

arunhep commented Mar 21, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a8fd6b1 into cms-sw:master Mar 21, 2017
@mmusich
Copy link
Contributor Author

mmusich commented Mar 21, 2017

release-note: protects SiStripGains PCL algorithm when analyzing ALCARECO data produced with versions not containing #17419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants