New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[91X] fix ShallowEventDataProducer to allow running SiStripGain PCL producers from 2016 ALCARECO #17981
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiStripCommon @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
attn: @dimattia |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
release-note: protects SiStripGains PCL algorithm when analyzing ALCARECO data produced with versions not containing #17419 |
Greetings,
this PR fixes the problem introduced in #17570, which unfortunately breaks the mode in which
ALCA:PromptCalibProdSiStripGainsAfterAbortGap
is invoked to run on existingALCARECO
datasets (e.g. 2016 ones) that don't have the LumiScalers collection. At present:fails with:
This running mode (which is NOT the one used at Tier-0) is anyway needed for large statistics study in view of improving the monitoring for 2017.
After internal discussions, in the same PR we propose to add
LumiScalers
andDcsStatus
collections also in theSiStripCalMinBiasAfterAbortGap
ALCARECO (as it was done for regularSiStripCalMinBias
in #17419) an effective increase of ~135b/evt.