Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task based stream begin transitions #17982

Merged
merged 2 commits into from Mar 20, 2017

Conversation

Dr15Jones
Copy link
Contributor

Switched to using per module tasks for stream begin Run and begin LuminosityBlock. All tasks for a transition are scheduled simultaneously thereby allowing multiple modules to run. During these stream transitions, there should be no inter-module dependencies.

Schedule each module into its own task when processing a stream begin Run or begin LuminosityBlock transition. All modules are allowed to run simultaneously without any inter-module dependencies.
Exactly where each piece of context for an exception message was being applied was dependent upon the type of transition which was running. Attempted to make this more uniform.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18540/console Started: 2017/03/18 20:56

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 933b415 into cms-sw:master Mar 20, 2017
@Dr15Jones Dr15Jones deleted the taskBasedStreamBeginTransitions branch March 30, 2017 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants