Backport of ECAL offline selective readout for TSG studies

[emanueledimarco]

This is a backport of the PR #17794 for 90X, needed for TSG studies (@Martin-Grunewald requested)

@bendavid @amassiro @shervin86 @argiro @crovelli @fcouderc @paramatti @gzevi please also follow this

[cmsbuild]

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_9_0_X.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[cmsbuild]

Pull request #18016 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18599/console Started: 2017/03/21 18:48

[cmsbuild]

-1

Tested at: 60cecc1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18016/18599/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #18016 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18615/console Started: 2017/03/22 02:56

[cmsbuild]

+1
Tested at: 3051157
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18016/18615/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #18016 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @franzoni, @slava77, @davidlange6 can you please check and sign again.

[emanueledimarco]

added the ECAL SRflags digis to the RECO format, as in PR #18141

[slava77]

I missed a comma here; now recovered in the #18141
Please pick it up as well

[cmsbuild]

Pull request #18016 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @franzoni, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18835/console Started: 2017/03/31 15:02

[cmsbuild]

+1
Tested at: 8ad3f80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18016/18835/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18016/18835/summary.html

[Martin-Grunewald]

+1

[slava77]

+1

for #18016 8ad3f80

• updates since the last reco signoff are to include updates to RECO event content to keep reco-from-reco sequence running https://github.com/cms-sw/cmssw/pull/18016/files/db74547370b9207aa4e0f14813511877267ae2e0..8ad3f805386a56046135898497fc3a748a101969, the same change as in add ecal digi SR flags to FEVT and RECO #18141 713d5c2
• jenkins tests pass

[slava77]

@davidlange6
please clarify when is this PR going to be merged in 90X.
I thought that this was an essential ingredient.

[davidlange6]

its being checked in pre2 (where it looks like things got requested to ops on Friday)

[cerminar]

Hello @davidlange6
any reason why this didn't enter in 901? This is delaying the PF calibration exercise.
Can we have a patch asap?
Thanks,
G

[rafaellopesdesa]

@davidlange6 Sorry for the many questions, but since I am one of the main users of this PR, I have a question: is the plan to have an immediate patch release in 90X once this is validated in 91X?

Thanks,
-- Rafael.

[davidlange6]

yes - this late development is holding up a number of things..

…

On Apr 10, 2017, at 1:45 PM, Rafael Lopes de Sa ***@***.***> wrote: @davidlange6 Sorry for the many questions, but since I am one of the main users of this PR, I have a question: is the plan to have an immediate patch release in 90X once this is validated in 91X? Thanks, -- Rafael. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.