Fix problem introduced by recent PR #17950 related to dropOnInput #18022
Conversation
The intent is that dropOnInput removes entries in the ProductRegistry in addition to dropping the products. The recent commit inadvertently disabled that for branches that were already dropped. And also this exposed the fact that GetterOfProducts requires dictionaries for all products in the ProductRegistry, even the dropped ones. And this should not be necessary and wastes a little CPU, so that is fixed also.
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
Comparison job queued. |
|
+1 |
The intent is that dropOnInput removes entries in the
ProductRegistry in addition to dropping the products.
The recent commit inadvertently disabled that for branches
that were already dropped.
And also this exposed the fact that GetterOfProducts requires
dictionaries for all products in the ProductRegistry, even the
dropped ones. And this should not be necessary for dropped branches
and wastes a little CPU, so that is fixed also.