Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to maintainability for Tasks used in PAT #18057

Merged
merged 1 commit into from Apr 5, 2017

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 23, 2017

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoJets/JetProducers
RecoTauTag/Configuration

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @yslai, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@wddgit
Copy link
Contributor Author

wddgit commented Mar 23, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18656/console Started: 2017/03/23 21:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 3, 2017

+1

for #18057 e27cea9

  • minor refactoring (defines pileUpJetIDTask and boostedHPSPFTausTask to be used instead of redefining an equivalent in a few places
  • jenkins tests pass and comparisons show no differences

@davidlange6 davidlange6 merged commit 9819399 into cms-sw:master Apr 5, 2017
@wddgit wddgit deleted the taskImprovements branch August 2, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants