Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Timing vs BX plots, and modifying thresholds for laser quality #18067

Merged
merged 3 commits into from Apr 1, 2017
Merged

Adding Timing vs BX plots, and modifying thresholds for laser quality #18067

merged 3 commits into from Apr 1, 2017

Conversation

tanmaymudholkar
Copy link
Contributor

@tanmaymudholkar tanmaymudholkar commented Mar 24, 2017 •
edited

Companion to Deployment PR#455: dmwm/deployment#455

Link to 900 PR: #18069

  • Added new plots for the average partition timing v/s BX number.
  • Changed expected values of laser timing from 4.2 clocks to 3.7 clocks for Laser 2. Also changed (the value of the deviation from the expected timing above which bad quality is triggered) to 1.0.

@tanmaymudholkar
Added new plot for mean partition timing vs BX to TimingTask.
b62bdfe
@tanmaymudholkar
Changed expected value of laser timing for green laser, changed the d…
f957a08 
…eviation from this expected value which triggers RED in the quality plot, and changed the binning range to more clearly see the full shape.
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 24, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for master.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

This was referenced Mar 24, 2017
Merged
Merged
@tanmaymudholkar tanmaymudholkar changed the title Timing vs bx and laser timing 91 x Adding Timing vs BX plots, and modifying thresholds for laser quality Mar 24, 2017
@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18682/console Started: 2017/03/24 20:47

@cmsbuild
Copy link
Contributor

-1

Tested at: f957a08

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18067/18682/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

  • Unit Tests:

I found errors in the following unit tests:

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
  • AddOn:

I found errors in the following addon tests:

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18711/console Started: 2017/03/27 09:01

@cmsbuild
Copy link
Contributor

Pull request #18067 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18814/console Started: 2017/03/31 08:32

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: e131c90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18067/18814/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18067/18814/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e502e82 into cms-sw:master Apr 1, 2017
@tanmaymudholkar tanmaymudholkar deleted the TimingVsBX_and_LaserTiming_91X branch April 27, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanmaymudholkar @cmsbuild @davidlange6 @dmitrijus