Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded Random Number Service - Generators #1807

Merged
merged 3 commits into from Dec 15, 2013

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Dec 13, 2013

First part of modifications to make the generators
use the new multithreaded random number service.
This includes all changes for the Pythia8GeneratorFilter.

HadronizerFilter and GeneratorFilter now get the random
number engine in their filter and beginLuminosityBlock
method. These engines are percolated in various ways
to where they are used. Classes are modified to only
generate random numbers in the event and beginLuminosityBlock
methods.

For Pythia8GeneratorFilter this required changes to
Pythia8Hadronizer and also the EvtGen, Photos,
and Tauola external decayers. Other generators
(for example Pythia6) are not broken by these changes,
but have not been modified yet.

HadronizerFilter and GeneratorFilter also declare
shared resources.

First part of modifications to make the generators
use the new multithreaded random number service.
This includes all changes for the Pythia8GeneratorFilter.

HadronizerFilter and GeneratorFilter now get the random
number engine in their filter and beginLuminosityBlock
method. These engines are percolated in various ways
to where they are used. Classes are modified to only
generate random numbers in the event and beginLuminosityBlock
methods.

For Pythia8GeneratorFilter this required changes to
Pythia8Hadronizer and also the EvtGen, Photos,
and Tauola external decayers. Other generators
(for example Pythia6) are not broken by these changes,
but have not been modified yet.

HadronizerFilter and GeneratorFilter also declare
shared resources.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X.

Multithreaded Random Number Service - Generators

It involves the following packages:

GeneratorInterface/Pythia6Interface
GeneratorInterface/Pythia8Interface
FastSimulation/ParticleDecay
FWCore/ServiceRegistry
GeneratorInterface/Core
GeneratorInterface/ExternalDecays
FastSimulation/TrajectoryManager
FWCore/Concurrency

@vciulli, @Dr15Jones, @lveldere, @cmsbuild, @nclopezo, @giamman, @ktf can you please review it and eventually sign? Thanks.
@inugent, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

};

std::string uniqueSharedResourceName();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about what this is for?

@cmsbuild
Copy link
Contributor

Pull request #1807 was updated. @vciulli, @Dr15Jones, @lveldere, @cmsbuild, @nclopezo, @giamman, @ktf can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1

1 similar comment
@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Dec 15, 2013

Vitaliano, I'm bypassing your signature here. Complain if not ok.

ktf added a commit that referenced this pull request Dec 15, 2013
Multithreaded Random Number Service - Generators
@ktf ktf merged commit 4adeac5 into cms-sw:CMSSW_7_0_X Dec 15, 2013
@wddgit wddgit deleted the threadsGeneratorRandomNumbers branch February 11, 2014 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants