New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreaded Random Number Service - Generators #1807
Conversation
First part of modifications to make the generators use the new multithreaded random number service. This includes all changes for the Pythia8GeneratorFilter. HadronizerFilter and GeneratorFilter now get the random number engine in their filter and beginLuminosityBlock method. These engines are percolated in various ways to where they are used. Classes are modified to only generate random numbers in the event and beginLuminosityBlock methods. For Pythia8GeneratorFilter this required changes to Pythia8Hadronizer and also the EvtGen, Photos, and Tauola external decayers. Other generators (for example Pythia6) are not broken by these changes, but have not been modified yet. HadronizerFilter and GeneratorFilter also declare shared resources.
…readsGeneratorRandomNumbers
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X. Multithreaded Random Number Service - Generators It involves the following packages: GeneratorInterface/Pythia6Interface @vciulli, @Dr15Jones, @lveldere, @cmsbuild, @nclopezo, @giamman, @ktf can you please review it and eventually sign? Thanks. |
}; | ||
|
||
std::string uniqueSharedResourceName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment about what this is for?
+1 |
1 similar comment
+1 |
Vitaliano, I'm bypassing your signature here. Complain if not ok. |
Multithreaded Random Number Service - Generators
First part of modifications to make the generators
use the new multithreaded random number service.
This includes all changes for the Pythia8GeneratorFilter.
HadronizerFilter and GeneratorFilter now get the random
number engine in their filter and beginLuminosityBlock
method. These engines are percolated in various ways
to where they are used. Classes are modified to only
generate random numbers in the event and beginLuminosityBlock
methods.
For Pythia8GeneratorFilter this required changes to
Pythia8Hadronizer and also the EvtGen, Photos,
and Tauola external decayers. Other generators
(for example Pythia6) are not broken by these changes,
but have not been modified yet.
HadronizerFilter and GeneratorFilter also declare
shared resources.