Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenParticles2HepMC for MiniAOD #18115

Merged
merged 6 commits into from Apr 20, 2017
Merged

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Mar 29, 2017

This PR enables to reproduce HepMC from the prunedGenParticles+packedGenParticles in the MiniAOD, to be used in the Rivet analyses.

For the RECO/AOD's, the workflow remains same: genParticles -> genParticle2HepMC ->rivetAnalyzer
and for the MiniAOD users: prunedGenParticles+packedGenParticles -> mergedGenParticles -> genParticles2HepMC -> RivetAnalyzer

The MergedGenParticleProducer is developed by @dsperka, @ajgilbert, @perrozzi for the Higgs group, with modification to the GenParticles2HepMCConverter to assign the "signal vertex".
(https://indico.cern.ch/event/596884/contributions/2436141/attachments/1396171/2128423/HTXS_GENmeeting_16Jan.pdf#page=10 https://twiki.cern.ch/twiki/bin/view/CMS/HiggsTemplateCrossSection)
The signal vertex assignment can be done by adding PDG id of the interested particle in the configuration, e.g., process.genParticles2HepMC.signalParticlePdgIds = cms.vint32(25). Default value assigns the first one to be the signal vtx.

The suggested codes are modified by @intrepid42 - inserts dummy pions to make Rivet to distinguish particles from hadron decay which are dropped during the pruning. This trick is necessary to construct pseudo-top. (https://indico.cern.ch/event/607918/contributions/2450369/attachments/1405142/2146446/Elvire_170201.pdf#page=5 https://indico.cern.ch/event/610889/contributions/2463094/attachments/1412258/2160811/PseudoTopRivet.pdf#page=10)

This is supposed to run at the user analysis level, therefore it does not change the central workflows.

(contents are modified to leave original contributers of the codes)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18770/console Started: 2017/03/29 10:25

@perrozzi
Copy link
Contributor

(to be fair, most of the credit goes to David Sperka @dsperka and Andrew Gilbert)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@jhgoh
Copy link
Contributor Author

jhgoh commented Mar 29, 2017

Main body is modified to include main contributors.

@@ -3,4 +3,6 @@
genParticles2HepMC = cms.EDProducer("GenParticles2HepMCConverter",
genParticles = cms.InputTag("genParticles"),
Copy link
Contributor

@perrozzi perrozzi Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to add another commented line like
genParticles = cms.InputTag("mergedGenParticles"), # in case mergedGenParticles are created
or add an example in the test directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added commented line just below of line 4, also added a cfg file under the test directory.

@cmsbuild
Copy link
Contributor

Pull request #18115 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

@jhgoh
Copy link
Contributor Author

jhgoh commented Apr 19, 2017

@davidlange6 simplified code by using simple vector and basic std::find.

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19249/console Started: 2017/04/19 14:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18115/19249/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1623 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826205
  • DQMHistoTests: Total failures: 34998
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1791034
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b5ad3f4 into cms-sw:master Apr 20, 2017
@jhgoh jhgoh deleted the MergedGenParticles branch April 21, 2017 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants