Combined tools for muon system aging/masking for upgrade studies #18199

battibass · 2017-04-04T17:03:58Z

The present pull requests collects work from different developers [1]. It extends the set of tools used by the muon community to provide results for the Scope Document and bring them to CMSSW for inclusion in (dedicated) productions or RelVals.

It provides:

A format to generate aging/masking conditions for the different subsystems
Different EDProducers to generate "degraded" version of the muon system digis
Cff snippets used in a customise function to plug "degraded" digis into offline RECO

It is aimed to be used for muon TDR studies, to mimic failures or aging (by means of removal of digis), and it is applied as customization as it is not meant for general inclusions in all production workflows.

Some details on code and use cases are given in the "Background, longevity and failure rate scenarios" session of the last Muon Upgrade Workshop.

@calabria @jshlee : please complete the descriptions with whatever relevant might be missing.

[1] CSC : @aminnj, RPC : @bapavlov, GEM : @sunilUIET, DT : @battibass

CSC aging integration for 90X

cmsbuild · 2017-04-04T17:04:23Z

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

CondCore/MuonSystemAgingPlugins
CondFormats/DataRecord
CondFormats/MuonSystemAging
DPGAnalysis/MuonSysAging

The following packages do not have a category, yet:

CondCore/MuonSystemAgingPlugins
CondFormats/MuonSystemAging
DPGAnalysis/MuonSysAging
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

battibass · 2017-04-05T09:33:13Z

@kpedro88 this tool is needed for the Muon TDR so, even if not automatically warned by the PR, this is to include you in the loop.

kpedro88 · 2017-04-05T13:44:34Z

assign upgrade

cmsbuild · 2017-04-05T13:44:55Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

kpedro88 · 2017-04-05T13:45:15Z

Please follow the instructions from the bot:

The following packages do not have a category, yet:

CondCore/MuonSystemAgingPlugins
CondFormats/MuonSystemAging
DPGAnalysis/MuonSysAging
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

battibass · 2017-04-05T14:32:37Z

@kpedro88:

if the action is on me I can do it (I do not know if something like this should be done by L2s of some kind).
Anyhow I would know what to do for CondCore/MuonSystemAgingPlugins and CondFormats/MuonSystemAging but I would need some input about where to place DPGAnalysis/MuonSysAging.
Actually, at first order, I would like to ensure that DPGAnalysis/MuonSysAging is the correct place for the EDProducers.

kpedro88 · 2017-04-05T16:19:01Z

@battibass in general we prefer developers to add their own new packages to cms-bot categories, as long as the assignments are obvious.

@davidlange6 can you remark on the new package categories, subsystems, dependencies, etc. before I proceed with the broader code review?

kpedro88 · 2017-04-06T14:16:23Z

DPGAnalysis/MuonSysAging/plugins/CSCChamberMasker.cc

+// class declaration
+//
+
+class CSCChamberMasker : public edm::EDProducer 


This class needs to be a modern producer (probably an edm::stream::EDProducer)

kpedro88 · 2017-04-06T14:17:25Z

DPGAnalysis/MuonSysAging/plugins/CSCChamberMasker.cc

+
+          // Since lookups are chamber-centric, make new DetId with layer=0
+          CSCDetId chId = CSCDetId(cscDetId.endcap(), cscDetId.station(), cscDetId.ring(), cscDetId.chamber(), 0);
+          // std::cout<<"Det id: " << chId<<std::endl;


remove all commented-out code

kpedro88 · 2017-05-04T14:28:35Z

please test

cmsbuild · 2017-05-04T14:28:56Z

The tests are being triggered in jenkins.

cmsbuild · 2017-05-04T14:29:10Z

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

slava77 · 2017-05-04T14:31:33Z

looks like this is now in 92X milestone.
This is the default without an IB yet.

kpedro88 · 2017-05-04T18:38:38Z

please test

cmsbuild · 2017-05-04T18:39:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19580/console Started: 2017/05/04 20:39

cmsbuild · 2017-05-04T19:40:13Z

+1
Tested at: ad5024a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18199/19580/summary.html

cmsbuild · 2017-05-04T19:40:17Z

Comparison job queued.

cmsbuild · 2017-05-04T21:41:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18199/19580/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3336 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1831050
DQMHistoTests: Total failures: 61697
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1769172
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

civanch · 2017-05-05T06:28:09Z

+1

franzoni · 2017-05-05T13:45:42Z

+1

sunilUIET and others added 12 commits March 17, 2017 13:59

cleaned setup

12f6eb9

Merged muonSysAging91X_v2 from repository sunilUIET

92742ba

add CSC filtering

e5940bd

Merge pull request cms-sw#2 from aminnj/csc-aging-integration_90X_v1

36b7f40

CSC aging integration for 90X

Merged muonSysAging91X_v2 from repository sunilUIET

13becad

fixes for GEM masking and ME0 masking included

677e912

Merged muonSysAging91X_v2 from repository sunilUIET

be3966a

fix for ME0

655ef2d

Merged muonSysAging91X_v2 from repository sunilUIET

d1fa703

Removed MuonSysAging duplicate

64ce9f6

Cleanup before any integration

0cbe770

Merging of DT, RPC, CSC, GEM, ME0 aging and masking tools

2654ace

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 4, 2017

cmsbuild added alca-pending comparison-pending db-pending new-package-pending orp-pending pending-signatures tests-pending labels Apr 4, 2017

cmsbuild added the upgrade-pending label Apr 5, 2017

kpedro88 reviewed Apr 6, 2017

View reviewed changes

smuzaffar modified the milestones: CMSSW_9_2_X, CMSSW_9_1_X May 4, 2017

cmsbuild added tests-rejected and removed tests-pending labels May 4, 2017

battibass mentioned this pull request May 4, 2017

Combined tools for muon system aging/masking for upgrade studies (91X) #18571

Merged

cmsbuild added tests-pending and removed tests-rejected labels May 4, 2017

cmsbuild added tests-started and removed tests-pending labels May 4, 2017

cmsbuild added tests-approved and removed tests-started labels May 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 4, 2017

cmsbuild added simulation-approved and removed simulation-pending labels May 5, 2017

davidlange6 merged commit a5633ad into cms-sw:master May 5, 2017

cmsbuild added alca-approved and removed alca-pending labels May 5, 2017

battibass deleted the muonSysAgingComb91X branch April 5, 2023 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combined tools for muon system aging/masking for upgrade studies #18199

Combined tools for muon system aging/masking for upgrade studies #18199

battibass commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 •

edited by smuzaffar

battibass commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

battibass commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

kpedro88 Apr 6, 2017

battibass Apr 7, 2017

kpedro88 Apr 6, 2017

battibass Apr 7, 2017

kpedro88 commented May 4, 2017

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

slava77 commented May 4, 2017

kpedro88 commented May 4, 2017

cmsbuild commented May 4, 2017 •

edited

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

civanch commented May 5, 2017

franzoni commented May 5, 2017

Combined tools for muon system aging/masking for upgrade studies #18199

Combined tools for muon system aging/masking for upgrade studies #18199

Conversation

battibass commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 • edited by smuzaffar

battibass commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

battibass commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

kpedro88 Apr 6, 2017

Choose a reason for hiding this comment

battibass Apr 7, 2017

Choose a reason for hiding this comment

kpedro88 Apr 6, 2017

Choose a reason for hiding this comment

battibass Apr 7, 2017

Choose a reason for hiding this comment

kpedro88 commented May 4, 2017

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

slava77 commented May 4, 2017

kpedro88 commented May 4, 2017

cmsbuild commented May 4, 2017 • edited

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

cmsbuild commented May 4, 2017

civanch commented May 5, 2017

franzoni commented May 5, 2017

cmsbuild commented Apr 4, 2017 •

edited by smuzaffar

cmsbuild commented May 4, 2017 •

edited