Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated runTheMatrix: un-used code clean and new options for IB #18208

Merged
merged 3 commits into from Apr 5, 2017
Merged

updated runTheMatrix: un-used code clean and new options for IB #18208

merged 3 commits into from Apr 5, 2017

Conversation

smuzaffar
Copy link
Contributor

  • un-used code cleanup
  • new option --maxStep=n added to run only first n steps
  • if --step1=True is passed then only step1 is run and for rest of the steps it generates a wf_steps.txt file with all the exact commands to be run. Note the -n -e doe snot show the exact commands (input and output files are missing)

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18933/console Started: 2017/04/05 10:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @davidlange6, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

@davidlange6 , if no objections then I would like to get this merged

@davidlange6
Copy link
Contributor

hi @smuzaffar - i'm a bit lost by the "step1only" changes, which naively look like an option that is obsoleted by the maxsteps option. Was this step1only not fully implemented before?

@smuzaffar
Copy link
Contributor Author

currently, the --step1 option is only used with --showMatrix|-n to dump the das queries. --maxStep could replace --step1 one-day but for now I did not want to change the interface (no idea if any one outside is using it).

@smuzaffar
Copy link
Contributor Author

I can update the PR so that WorkFlowRunning only use on maxStep

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

@davidlange6
Copy link
Contributor

davidlange6 commented Apr 5, 2017 via email

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18937/console Started: 2017/04/05 13:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Apr 5, 2017

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@smuzaffar
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Pull request #18208 was updated. @cmsbuild, @GurpreetSinghChahal, @davidlange6, @kpedro88, @fabozzi can you please check and sign again.

@smuzaffar
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Apr 5, 2017
@smuzaffar smuzaffar merged commit f83c425 into cms-sw:master Apr 5, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants