Converted HcalDigiToRaw to global module

[sabasehrish]

No description provided.

[cmsbuild]

A new Pull Request was created by @sabasehrish for master.

It involves the following packages:

EventFilter/HcalRawToDigi

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18959/console Started: 2017/04/06 00:53

[cmsbuild]

+1
Tested at: 4b370be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18225/18959/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18225/18959/summary.html

[perrotta]

For the conversion, it may also be advisabe to make const in HcalDigiToRaw.h the edm::InputTag and the edm::EDGetTokenT class elements: do you plan to do so?

[sabasehrish]

Yes, I will create a new pull request.

[perrotta]

@sabasehrish : why a new pull request???
Please update this one if you just want to make const those class elements

[cmsbuild]

Pull request #18225 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[sabasehrish]

I am not done with all my changes yet, I will let you know when to check awn sign again. Thanks.

[cmsbuild]

Pull request #18225 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[sabasehrish]

I am done with my changes.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19072/console Started: 2017/04/10 22:03

[cmsbuild]

+1
Tested at: c010bfb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18225/19072/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18225/19072/summary.html

Comparison Summary:

• You potentially added 33 lines to the logs
• Reco comparison results: 1630 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1917243
• DQMHistoTests: Total failures: 9506
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1907564
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[perrotta]

+1
Technical
Conversion to global module looks correct
No effect on standard workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1