New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate cfi for hltScoutingPrimaryVertexproducer #18262
Conversation
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_9_0_X. It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
backport of #18263 |
please test |
The tests are being triggered in jenkins. |
type bug-fix |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -71,6 +71,8 @@ void | |||
HLTScoutingPrimaryVertexProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) { | |||
edm::ParameterSetDescription desc; | |||
desc.add<edm::InputTag>("vertexCollection", edm::InputTag("hltPixelVertices")); | |||
descriptions.add("hltScoutingPrimaryVertexproducer", desc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalisation: "hltScoutingPrimaryVertexProducer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so I will make this small change and push in the same branch again.
Pull request #18262 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison is ready Comparison Summary:
|
+1 |
No description provided.