Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate cfi for hltScoutingPrimaryVertexproducer #18262

Merged
merged 2 commits into from Apr 11, 2017

Conversation

swagata87
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_9_0_X.

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor

backport of #18263

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19006/console Started: 2017/04/07 16:36

@Martin-Grunewald
Copy link
Contributor

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18262/19006/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1915960
  • DQMHistoTests: Total failures: 44294
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1871493
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@@ -71,6 +71,8 @@ void
HLTScoutingPrimaryVertexProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("vertexCollection", edm::InputTag("hltPixelVertices"));
descriptions.add("hltScoutingPrimaryVertexproducer", desc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalisation: "hltScoutingPrimaryVertexProducer"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I will make this small change and push in the same branch again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

Pull request #18262 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19033/console Started: 2017/04/09 09:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18262/19033/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1915960
  • DQMHistoTests: Total failures: 121
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1915666
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 604bb9f into cms-sw:CMSSW_9_0_X Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants